-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: result extraction for incompressible media now based on real density #640
Bugfix: result extraction for incompressible media now based on real density #640
Conversation
I see your point but I don't agree totally with your adaptions. vf is actually defined as standard flow rate. This is also extracted as result in liquid fluids. If you change vf the way you do, the results are misleading in my opinion. I guess we have to possibilities: In terms of the velocities I agree and we should correct the bug accordingly |
…ing on fluid type
pandapower only supports python >=3.9 on develop. The tutorial tests are still running with pandapower develop, which is why also required tests fail, not just the relying tests. I guess we should change this to pandapower master? Should I do it in this PR? @SimonRubenDrauz @EPrade |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #640 +/- ##
===========================================
- Coverage 86.02% 85.63% -0.40%
===========================================
Files 90 90
Lines 6497 6500 +3
===========================================
- Hits 5589 5566 -23
- Misses 908 934 +26 ☔ View full report in Codecov by Sentry. |
This is now handled differently for compressible / incompressible media |
…(not density at normal conditions); added tests for correct behavior in temperature calculation, including convergence to good fluid properties from bad starting values in bidirectional mode
…ame value instead of calculating density for same value many times based on list
…l_density # Conflicts: # CHANGELOG.rst # src/pandapipes/component_models/flow_control_component.py # src/pandapipes/component_models/heat_consumer_component.py # src/pandapipes/component_models/heat_exchanger_component.py # src/pandapipes/component_models/pipe_component.py # src/pandapipes/component_models/pressure_control_component.py # src/pandapipes/component_models/pump_component.py # src/pandapipes/component_models/valve_component.py # src/pandapipes/pf/result_extraction.py
No description provided.