-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hydraulics of hot water in pipe: Unexpected effects of temperatures on pressure drop #639
Comments
On the develop branch, we implemented a new calculation mode "bidirectional" which would probably lead to more expected results. If you would like to test it with your example, we gladly use your feedback to make further improvements. I am not quite sure how to interpret the "real" pipe temperature, as temperature is hard to grasp for a component along which it changes. It will always be some intermediate value and must be derived from specific locations, which are usually the network nodes, in my opinion. But I would be interested in further ideas. |
I just found that there was a bug in the result extraction for incompressible media. I opened pull request #640 as a fix. It will be on develop soon, I will also clarify how we can release it rather soon. |
I totally agree, that "the" temperature in a pipe does not exist. |
If I use your bugfix from #640 and the mode "bidirectional" that you mentioned, I actually get results, that look more like I expected:
|
@SimonRubenDrauz can you check the following line of code again:
|
With respect to the heat capacity, I could imagine that it should be part of the fluid property itself to find the mean value within a certain range, as the behavior can change a lot. So, if the dependency is e.g. quadratic, the property will have to find the integral for the given range and divide it by the range to retrieve the mean value. In case of interpolated points, the points within the range have to be evaluated and weighted by the respective distances. |
Hi @j-zipplies, I corrected the bug and added your snippet as a test so that this issue will not evolve again in future versions (a143789). This bug fix will be released soon. Thanks a lot for your support! |
Describe the bug
When simulating hot water in a pipe via pp.pipeflow(net, mode="all"), the results for velocity and re-Number => lambda and in final consequence the pressure drop have unexpected (in)dependencies on the temperatures. Probably, this comes from the way density and viscosity are calculated and the fact that hydraulic and thermal calculation are fully separated.
Density
Apparently the density does not depend at all on the temperatures in the net. It is apparently set at t=273.15 K (999.9 kg/m³).
In consequence, the flow velocity in res_pipes does not at all depend on the temperatures in the net, it just depends on mdot.
Viscosity
The viscosity seems to be calculated according to tfluid_k at junctions - or, if applicable, the temperature of external grid.
In consequence, reynolds numbers => lambda => pressure drop in the pipes depend on these temperatures.
To Reproduce
I set up an example, external grid => pipe1 => pipe2 => sink, with four different configurations of temperatures (tfluid_k at junctions and the t_k from the external grid are either 300 or 350).
Output:
The output demonstrates:
I guess, that this is an effect of using tfluid_k and t_k at external grids for the calculation of the viscosity (instead of the actual temperature of the fluid in the pipes).
Expected behavior
Use the actual temperatures of the fluid in the pipe to calculate the fluid properties and results, that depend on those (velocity, reynolds, lambda, pressure drop).
Python environment (please complete the following information):
Here velocity and reynolds only depend on tfluid_k at junctions: (which is somewhat more consistent than the pp 0.10.0 behavior)
Additional context
This issue is related to #384, and illustrates, that the fully separated hydraulic and thermal calculation as implemented now leads to confusing results.
The text was updated successfully, but these errors were encountered: