Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#24 - add Link and BinBin providers #117

Merged
merged 13 commits into from
Aug 22, 2023
Merged

Conversation

AleksandraKozubal
Copy link
Collaborator

@AleksandraKozubal AleksandraKozubal commented Aug 11, 2023

Added translation method in DataImporter, I think it could be helpful to solve issue #104.

It should close #24, and close #92

@AleksandraKozubal AleksandraKozubal requested a review from a team as a code owner August 11, 2023 08:51
@AleksandraKozubal AleksandraKozubal changed the title #24 - add Link provider #24 #92 - add Link provider Aug 14, 2023
@AleksandraKozubal AleksandraKozubal changed the title #24 #92 - add Link provider #24 #92 - add Link and BinBin provider Aug 14, 2023
@AleksandraKozubal AleksandraKozubal changed the title #24 #92 - add Link and BinBin provider #24, #92 - add Link and BinBin provider Aug 14, 2023
@AleksandraKozubal AleksandraKozubal changed the title #24, #92 - add Link and BinBin provider #24 - add Link and BinBin provider Aug 14, 2023
app/Importers/DataImporter.php Outdated Show resolved Hide resolved
app/Importers/BinBinDataImporter.php Outdated Show resolved Hide resolved
app/Importers/BinBinDataImporter.php Outdated Show resolved Hide resolved
@krzysztofrewak
Copy link
Contributor

Also: listing available providers in readme file would be a nice thing.

app/Importers/BinBinDataImporter.php Outdated Show resolved Hide resolved
readme.md Outdated Show resolved Hide resolved
app/Importers/BinBinDataImporter.php Outdated Show resolved Hide resolved
@krzysztofrewak krzysztofrewak changed the title #24 - add Link and BinBin provider #24 - add Link and BinBin providers Aug 21, 2023
app/Importers/DataImporter.php Outdated Show resolved Hide resolved
readme.md Show resolved Hide resolved
@AleksandraKozubal AleksandraKozubal merged commit 1678f5d into main Aug 22, 2023
@AleksandraKozubal AleksandraKozubal deleted the #24-Link-provider branch August 22, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add BinBin provider [Providers] Add Link provider
4 participants