Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#120 - fix load() in DataImporter.php #121

Merged
merged 9 commits into from
Aug 21, 2023
Merged

Conversation

AleksandraKozubal
Copy link
Collaborator

@AleksandraKozubal AleksandraKozubal commented Aug 17, 2023

Modified load(), it checks if city is assigned to given country.
Also there can be multiple cities that have the same name, so changed migration.

It should close #120

@AleksandraKozubal AleksandraKozubal requested a review from a team as a code owner August 17, 2023 11:36
@AleksandraKozubal AleksandraKozubal marked this pull request as draft August 18, 2023 04:59
@AleksandraKozubal AleksandraKozubal marked this pull request as ready for review August 18, 2023 11:05
app/Importers/DataImporter.php Outdated Show resolved Hide resolved
app/Importers/DataImporter.php Outdated Show resolved Hide resolved
app/Importers/DataImporter.php Outdated Show resolved Hide resolved
app/Importers/DataImporter.php Show resolved Hide resolved
@AleksandraKozubal AleksandraKozubal merged commit 4686ed3 into main Aug 21, 2023
@AleksandraKozubal AleksandraKozubal deleted the #120-fix-load branch August 21, 2023 05:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix load() in DataImporter.php
4 participants