Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup 2 #117

Merged
merged 9 commits into from
Nov 18, 2024
Merged

Cleanup 2 #117

merged 9 commits into from
Nov 18, 2024

Commits on Nov 18, 2024

  1. Move hamburger nav show/hide logic to Stimulus controller 

    We've used Stimulus for other JS, and this makes functionality clearer.
    @jdudley1123
    jdudley1123 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    2127de0 View commit details
    Browse the repository at this point in the history

  2. Combine JS files 

    There's no good reason to keep these as separate files, and combining them makes it easier to see what's going on.
    @jdudley1123
    jdudley1123 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b883b7d View commit details
    Browse the repository at this point in the history

  3. Remove unused file 

    This partial doesn't appear to be used anywhere. I think it's a leftover from an early prototype.
    @jdudley1123
    jdudley1123 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    df5aca0 View commit details
    Browse the repository at this point in the history

  4. Remove wrapper file 

    Wed on't need to wrap the location selector in another partial. This saves us a file.
    @jdudley1123
    jdudley1123 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b0d7c21 View commit details
    Browse the repository at this point in the history

  5. Simplify partial rendering calls 

    We can take advantage of Rails' defaults to write the rendering calls for partials more succinctly.
    @jdudley1123
    jdudley1123 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    b66bd9c View commit details
    Browse the repository at this point in the history

  6. Rename footer navigation partial for clarity 

    The footer navigation was just called 'navigation' which made it easy to confuse with the header navigation
    @jdudley1123
    jdudley1123 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    19f57bb View commit details
    Browse the repository at this point in the history

  7. Standardise DAQI styling 

    Rather than specifying the colours in the forecast tabs and the colours in the DAQI scale separately, we can define them all in CSS and then apply the same styles in both cases. This will make them easier to update in future.
    @jdudley1123
    jdudley1123 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    53d739b View commit details
    Browse the repository at this point in the history

  8. Simplify tab component CSS classes 

    We can simplify the tab component quite a bit to make it easier to manage.
    @jdudley1123
    jdudley1123 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    380c1d1 View commit details
    Browse the repository at this point in the history

  9. Move styles to stylesheet 

    Move the Tailwind class styles from individual elements to the stylesheet. This makes the HTML easier to understand.

Eventually we may replace Tailwind entirely.
    @jdudley1123
    jdudley1123 committed Nov 18, 2024
    Configuration menu
    Copy the full SHA
    6d1f890 View commit details
    Browse the repository at this point in the history