Cleanup 2 #117
Merged
Cleanup 2 #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We've used Stimulus for other JS, and this makes functionality clearer.
There's no good reason to keep these as separate files, and combining them makes it easier to see what's going on.
This partial doesn't appear to be used anywhere. I think it's a leftover from an early prototype.
Wed on't need to wrap the location selector in another partial. This saves us a file.
We can take advantage of Rails' defaults to write the rendering calls for partials more succinctly.
The footer navigation was just called 'navigation' which made it easy to confuse with the header navigation
Rather than specifying the colours in the forecast tabs and the colours in the DAQI scale separately, we can define them all in CSS and then apply the same styles in both cases. This will make them easier to update in future.
We can simplify the tab component quite a bit to make it easier to manage.
Move the Tailwind class styles from individual elements to the stylesheet. This makes the HTML easier to understand. Eventually we may replace Tailwind entirely.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes in this PR
This PR does some cleanup: