-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rusk-wallet: Add moonlight support #2289
Conversation
cd53964
to
da74081
Compare
3bab53c
to
0f4ceab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. The stake unstake functions are there for testing across rusk not exposed yet via rusk wallet
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Before I proceed with the review, I'd like to provide some general feedback. Please note that my review will focus solely on the wallet-core
section. I will ensure it is properly structured for both FFI/WASM and native support. As for the other areas, I will leave those to your discretion.
-
Remove
#![allow(clippy::module_name_repetitions)]
: If you are encountering Clippy warnings about module name repetitions, it suggests that the module, type, or function names are not appropriately chosen. The attribute is there for a reason, and removing it may help identify where naming improvements are needed. -
Avoid having a
phoenix
module: We already have anotes
module, and since I’ve movedphoenix_balance
there, we can consolidate. Thenotes
module can serve as a "discriminant," meaning we can have one model usingnotes
and another usingaccount
. Ensure that everything related to "notes" is handled within thenotes
namespace/module, and we can then decide how best to integrate moonlight from there.
I will proceed with the review of the wallet-core
section once the aforementioned points are addressed.
Please @moCello note that any changes to wallet-core
are currently blocking my work on FFI and w3sper. As my changes need to be built on top of yours, it’s crucial that your revisions are handled properly and promptly.
c1b2ff1
to
072b528
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
636a821
to
ce2a43d
Compare
Co-authored-by: Daksh <[email protected]>
Extend CLI interface to display moonlight balance Co-authored-by: Daksh <[email protected]>
Co-authored-by: Daksh <[email protected]>
4de4e2f
to
679f47c
Compare
Co-authored-by: Daksh <[email protected]>
edd8cf9
to
e11c701
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙌
This PR adds basic support of moonlight transactions.
In further issues we will also want to add specific methods to create moonlight-stake, moonlight-unstake and moonlight-stake-withdrawal transactions.
Resolves #2288