Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wallet-core: work on FFI #2308

Merged
merged 9 commits into from
Sep 9, 2024
Merged

wallet-core: work on FFI #2308

merged 9 commits into from
Sep 9, 2024

Conversation

ZER0
Copy link
Contributor

@ZER0 ZER0 commented Sep 9, 2024 •
edited
Loading

  • Change notes test to be close to SDK ones
  • Add map_owned FFI
  • Add balance FFI
  • Add OwnedList serializable type
  • Add ErrorCode usage
  • Move map_owned in notes module with OwnedList
  • Add FFI's ErrorCode enum and codes handling (requires try_trait_v2)
  • Add debugging capabilities
  • Add dbg! and eprintln! macros implementation for WASM host
  • Add panic handling for debug builds
  • Add rkyv
  • Add compiler optimizations
  • rusk-wallet: remove unnecessary Seed structure

Resolves #2315
Resolves #2317

moCello
moCello reviewed Sep 9, 2024
View reviewed changes
wallet-core/src/ffi.rs Outdated Show resolved Hide resolved
moCello
moCello reviewed Sep 9, 2024
View reviewed changes
wallet-core/src/notes.rs Outdated Show resolved Hide resolved
moCello
moCello reviewed Sep 9, 2024
View reviewed changes
wallet-core/src/lib.rs Outdated Show resolved Hide resolved
@ZER0 ZER0 force-pushed the wallet-core-ffi branch 2 times, most recently from b82286c to 2dc20b4 Compare September 9, 2024 14:20
@ZER0 ZER0 marked this pull request as ready for review September 9, 2024 14:41
@ZER0 ZER0 marked this pull request as draft September 9, 2024 14:42
ZER0 added 6 commits September 9, 2024 16:43
@ZER0
wallet-core: Add compiler optimizations
14509a6
@ZER0
wallet-core: Add rkyv
c4fae21
@ZER0
wallet-core: add debugging capabilities
be569d7 
- Add `dbg!` and `eprintln!` macros implementation for WASM host
- Add panic handling for debug builds

Resolves #2315
@ZER0
wallet-core: add FFI's ErrorCode enum and codes handling (requires `t…
13b91c6 
…ry_trait_v2`)
@ZER0
wallet-core: enable WASM host to calc balance for a profile
202145b 
- Add `map_owned` FFI
- Add `balance` FFI
- Add `OwnedList` serializable type
- Add `ErrorCode` usage
- Move `map_owned` in `notes` module with `OwnedList`

Resolves #2317
@ZER0
wallet-core: change notes test to be close to SDK ones
d5365aa
@ZER0 ZER0 added the module:rusk-wallet Issues related to rusk wallet label Sep 9, 2024
ZER0 added 3 commits September 9, 2024 17:30
@ZER0
wallet-core: Move some functionality from lib's root to notes module
44b8bfe 
- Add `NOTES_BUFFER_SIZE` to indicate the scratch buffer size for notes
- Add `MAX_INPUT_NOTES`, `phoenix_balance` and `BalanceInfo` under `notes` module
- Remove `MAX_INPUT_NOTES`, `phoenix_balance` and `BalanceInfo` from lib.rs
@ZER0
wallet-core: adjustment after rebasing with main branch
a2a0ae4
@ZER0
rusk-wallet: remove unnecessary Seed structure
0e3edbe
@ZER0 ZER0 marked this pull request as ready for review September 9, 2024 15:31
moCello
moCello approved these changes Sep 9, 2024
View reviewed changes
Copy link
Member

@moCello moCello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ZER0 ZER0 merged commit 7a259e9 into master Sep 9, 2024
27 of 30 checks passed
@ZER0 ZER0 deleted the wallet-core-ffi branch September 9, 2024 18:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@moCello moCello moCello approved these changes

Assignees
No one assigned
Labels
module:rusk-wallet Issues related to rusk wallet module:wallet-core
Projects
None yet
Milestone
No milestone
2 participants
@ZER0 @moCello