Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add benchmarks to CI #2139

Merged
merged 2 commits into from
Aug 21, 2024
Merged

Add benchmarks to CI #2139

merged 2 commits into from
Aug 21, 2024

Conversation

HDauven
Copy link
Member

@HDauven HDauven commented Aug 15, 2024

Resolves #1954

This is both a good and a bad idea. The good part is that we can frequently check incremental improvements and regressions. I currently set the criterion report retention to 3 days, but that might be too short.

The bad idea about this implementation is that it clogs up CI for ~20 minutes. And the results can be affected by other runs. We can opt to limit the number of tests (1 tx, 5 tx, 10 tx, 50 tx, 100 tx), make it run only as a triggerable action or only run it on merge commits.

@HDauven HDauven force-pushed the feature-1954 branch 2 times, most recently from a460a14 to 405a387 Compare August 15, 2024 22:27
@HDauven HDauven requested a review from ureeves August 16, 2024 07:12
Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would indeed do this only once it merges. That way, we ensure we ensure we don't clog up any PRs but still get a signal if the benches fail.

@HDauven
Copy link
Member Author

HDauven commented Aug 18, 2024

I would indeed do this only once it merges. That way, we ensure we ensure we don't clog up any PRs but still get a signal if the benches fail.

What's your view on limiting the number of TX benches?

@HDauven
Copy link
Member Author

HDauven commented Aug 21, 2024

Benchmarks are only executed on a merge commit to main. Updated retention to 14 days, given the output is only 1.5MB.

Copy link
Member

@ureeves ureeves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@ureeves
Copy link
Member

ureeves commented Aug 21, 2024

I would indeed do this only once it merges. That way, we ensure we ensure we don't clog up any PRs but still get a signal if the benches fail.

What's your view on limiting the number of TX benches?

I think if we run them all only on a merge to master it should be fine. Its nice to have all of that data

@HDauven HDauven merged commit 282c8d2 into master Aug 21, 2024
16 checks passed
@HDauven HDauven deleted the feature-1954 branch August 21, 2024 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add benchmarks to Rusk CI
2 participants