-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
node: Reward Voters/Validators of previous block #1873
Conversation
…ccept with prev_block_voters
- Proper set of voters here means the voters that generate the candidate_block.prev_block_cert - The mutex around executor instance is removed to avoid deadlock
da56bdc
to
2f97b02
Compare
@goshawk-3 There are some unanswered comments from my previous review (maybe you missed them since they were hidden by github). Please address/answer them before I approve the PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
resolves #1832
Acceptance criteria:
est/vst/accept/finalize
should use voters list of tip attestationverify_block_header