Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node: Check Certificate is Success Attestation #1905

Closed
fed-franz opened this issue Jul 2, 2024 · 0 comments · Fixed by #1985
Closed

node: Check Certificate is Success Attestation #1905

fed-franz opened this issue Jul 2, 2024 · 0 comments · Fixed by #1985
Assignees
@fed-franz
Labels
fix:bug Something isn't working module:consensus Issues related to consensus module

Comments

@fed-franz
Copy link
Contributor

fed-franz commented Jul 2, 2024 •
edited
Loading

Summary

In verify_prev_block_cert, the validity of the previous block Certificate if verified. However, the simple validity of the Attestation is insufficient here, since a Certificate MUST be a Success Attestation.
We need to check this is the case.

Originally posted by @fed-franz in #1873 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fed-franz fed-franz

Labels
fix:bug Something isn't working module:consensus Issues related to consensus module
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

node: Check Certificate is Success Attestation dusk-network/rusk
2 participants
@autholykos @fed-franz