Implement resource discovery by "Flood with Random Walk" algorithm #1711
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
May 7, 2024 18:31
fed-franz
reviewed
May 13, 2024
There was a problem hiding this comment.
I'd suggest to use a counter TTL instead of timestamp.
Generally speaking, relying on timestamps in a distributed network is never a great approach, since it relies on local node clocks to be synchronized.
While we're considering having nodes use NTP, we should not rely on it if not necessary.
Additionally, using a counter allows to better control the maimum number of hops the request will go through, regardless of the latency.
added 6 commits
May 13, 2024 14:39
fed-franz
reviewed
May 14, 2024
fed-franz
requested changes
May 16, 2024
goshawk-3
commented
May 17, 2024
added 4 commits
May 21, 2024 11:24
- Use request_block_by_height to initialize a presync procedure - Update default hops_limit to 128 - Update DEFAULT_CERT_CACHE_EXPIRY to 1min - Fix the condition for detecting sync target is reached
fed-franz
requested changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #1528
Resolves #1722
Acceptance criteria:
GetBlocksmessage flow works properly as usual. It should not triggerflood_requestGetData/GetResourceusesflood_requestto retrieve a resource (block/transaction) from a distant peer.GetData/GetResourcelimits aflood_requestbyhops_limitsetting.certificate cacheis cleaned up properlyMempoolmessage returns mempoolNB: Testing the impl of this approach revealed a race condition that was (most probably) previously happening too. It'll be addressed with #1722