Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

node: Extend GetResource message flow to provide Candidate block #1713

Closed
goshawk-3 opened this issue May 8, 2024 · 0 comments · Fixed by #1831
Closed

node: Extend GetResource message flow to provide Candidate block #1713

goshawk-3 opened this issue May 8, 2024 · 0 comments · Fixed by #1831
Assignees
Labels
priority:minor Low priority issues

Comments

@goshawk-3
Copy link
Contributor

Summary

💡 Use "Flooding with Random Walk" impl (if beneficial for) in GetCandidate message flow.

Context: GetCandidate P2P message is currently used in creating the winner block in consensus task on Quorum message arrival. It sends request to 7 random (alive) peers and waits for a response 2s. Together with that, GetCandidate search for block only in Candidates Column Family but it could also check the Ledger CF too.

Possible solution design or implementation

  • Deprecate GetCandidate message flow.
  • Extend GetResource msg flow to support CandidateFromHash Inventory type
  • Extend handle_get_candidate to search for a missing candidate in Ledger Column family

Additional context

GetResource (BlockFromHash) (called in Chain component on arrival of Quorum msg) overlaps with GetCandidate request.

depends on #1711

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority:minor Low priority issues
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant