Merge pull request #245 from dusk-network/mocello/244_zeroize_on_drop

core: Add comment on `ZeroizeOnDrop`
dusk-network · Sep 18, 2024 · d713e26 · d713e26
2 parents bc9dc67 + de5e503
commit d713e26
Showing 1 changed file with 5 additions and 0 deletions.
diff --git a/core/src/keys/secret.rs b/core/src/keys/secret.rs
@@ -42,6 +42,11 @@ use subtle::{Choice, ConstantTimeEq};
 ///
 /// sk.zeroize();
 /// ```
+///
+/// # Note
+/// Implementing `ZeroizeOnDrop` seems like an excellent way to lift the burden
+/// of manually zeroizing after use off the user, but unfortunately it doesn't
+/// delete the memory reliably. See #244
 #[derive(Clone, Eq, Debug, Zeroize)]
 #[cfg_attr(
     feature = "rkyv-impl",