Merge pull request #247 from dusk-network/mocello/246_owns

core: Avoid code duplication in `sk.owns` by calling `gen_note_sk`
dusk-network · Sep 18, 2024 · bc9dc67 · bc9dc67
2 parents 8d70fac + ea21daf
commit bc9dc67
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 4 deletions.
diff --git a/core/CHANGELOG.md b/core/CHANGELOG.md
@@ -7,6 +7,10 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 
 ## [Unreleased]
 
+### Changed
+
+- Call `gen_note_sk` in `SecretKey::owns` to avoid code duplication [#246]
+
 ## [0.32.0] - 2024-08-14
 
 ### Changed

diff --git a/core/src/keys/secret.rs b/core/src/keys/secret.rs
@@ -89,11 +89,9 @@ impl SecretKey {
 
     /// Checks if `note_pk ?= (H(R · a) + b) · G`
     pub fn owns(&self, stealth_address: &StealthAddress) -> bool {
-        let aR = stealth_address.R() * self.a();
-        let hash_aR = hash(&aR);
-        let note_sk = hash_aR + self.b();
+        let note_sk = self.gen_note_sk(stealth_address);
 
-        let note_pk = GENERATOR_EXTENDED * note_sk;
+        let note_pk = GENERATOR_EXTENDED * note_sk.as_ref();
 
         stealth_address.note_pk().as_ref() == &note_pk
     }