remove retry logic #100
Closed
remove retry logic #100
+12
−352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@drbrain does this look good ? ... if ye I'll start fixing the tests |
|
@drbrain looks like the right direction ? |
|
@drbrain looks like the right direction ? (I still need to change all the tests if yes) |
|
added tests @tenderlove are you able to merge since @drbrain seems to ignore this PR ? :( |
|
releasing this as net-http-persistent-retry so I can use it in my other projects and can declare an actual dependency, will yank if this ever gets merged 🤷♂ |
grosser
added a commit
to grosser/faraday
that referenced
this pull request
May 16, 2019
…implified (instead of `Faraday::ConnectionFailed`) In v3 net-http-persistent rescue a lot of exceptions and retries them or re-raises them as Net::HTTP::Persistent::Error which is complicated and unnecessary. When drbrain/net-http-persistent#100 gets merged (or when using [net-http-persistent-retry](https://github.com/grosser/net-http-persistent) which is a fork of net-http-persistent with that PR applied) the error wrapping/retry goes away and it will start raising "normal" errors like `Net::OpenTimeout` which is a `Timeout::Error`. /cc @drbrain @mislav @iMacTia
32 tasks
drbrain
added a commit
that referenced
this pull request
Apr 30, 2020
|
Merged, see log above. |
|
awesome, thx! :D |
xuxiangyang
added a commit
to xuxiangyang/thrift_rack
that referenced
this pull request
May 11, 2020
stim371
added a commit
to stim371/faraday
that referenced
this pull request
Oct 1, 2020
The net-http-persistent gem removed the #retry_change_requests adapter configuration with drbrain/net-http-persistent#100 in v4.0.0.
flavorjones
added a commit
to flavorjones/mechanize
that referenced
this pull request
Jan 23, 2021
Net::HTTP::Persistent removed `#retry_change_requests` in v4.0.0 and later, so these tests fail if we've pulled in a more recent version than that. Related to drbrain/net-http-persistent#100
flavorjones
added a commit
to sparklemotion/mechanize
that referenced
this pull request
Jan 23, 2021
Net::HTTP::Persistent removed `#retry_change_requests` in v4.0.0 and later, so these tests fail if we've pulled in a more recent version than that. Related to drbrain/net-http-persistent#100
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #37
fixes #89
@tenderlove @timanovsky @drbrain
not sure if this breaks RFC 2616 but idk what part of the readme it was referring to when it mentioned the RFC, I'd assume the closing the connection which is still there