Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add max_retries options to configure Net::HTTP idempotent request retry #112

Closed
dwiyanr opened this issue Dec 1, 2019 · 1 comment
Closed

Comments

@dwiyanr
Copy link

dwiyanr commented Dec 1, 2019

After the release of ruby 2.5.0, Net::HTTP by default retry idempotent request in case of failure ref. I think this can lead to unexpected behavior which needs to be configurable.
As far as I see, we cannot configure this in the current version of net-http-persistent. My suggestion is to add options for max_retries to pass to Net::HTTP

@drbrain
Copy link
Owner

drbrain commented Apr 29, 2020

Net::HTTP::Persistent no longer automatically retries requests as all versions of ruby it supports retry the requests automatically.

The option to enable retries will be removed in a future release, #100 is a PR to do this that is not yet merged.

@drbrain drbrain closed this as completed Apr 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants