Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SDPAP-7604] Add Redirect bulk import feature #404

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from
Open

[SDPAP-7604] Add Redirect bulk import feature #404

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
0d00d50
SDPAP-7604 - Add and install Path Redirect Import for bulk URL Redire…
meralvingrita24 May 10, 2023
467fa85
SDPAP-7604 - Apply a patch for path_redirect_import to handle warning…
meralvingrita24 May 10, 2023
5553734
SDPAP-7604 Update patch included for path_redirect_import module
meralvingrita24 May 18, 2023
b4335d2
Merge branch 'develop' into feature/SDPAP-7604-add-path-redirect-impo…
meralvingrita24 May 18, 2023
d3e3f6f
Merge branch 'develop' into feature/SDPAP-7604-add-path-redirect-impo…
meralvingrita24 May 31, 2023
810b30b
SDPAP-7604 - Fix PHP Code standard issues
meralvingrita24 May 31, 2023
15e9984
Merge branch 'develop' into feature/SDPAP-7604-add-path-redirect-impo…
christopher-hopper Jun 1, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions composer.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,7 @@
"drupal/password_policy": "dev-3.x",
"drupal/password_strength": "^2.0-alpha2",
"drupal/pathauto": "^1.3",
"drupal/path_redirect_import": "^2.0",
"drupal/prlp": "^1.3",
"drupal/redirect": "^1.3",
"drupal/role_delegation": "^1.0-alpha1",
Expand Down Expand Up @@ -254,6 +255,9 @@
"drupal/password_policy": {
"Add password validation to the user entity as a constraint - https://www.drupal.org/project/password_policy/issues/2941526#comment-14938934": "https://www.drupal.org/files/issues/2023-02-24/password_policy-move-password-validation-to-user-entity-2941526-10.patch"
},
"drupal/path_redirect_import": {
"Warning messages appear when the CSV's header are not following the suggested headers - https://www.drupal.org/project/path_redirect_import/issues/3359286": "https://www.drupal.org/files/issues/2023-05-18/path_redirect_import-handling-warning-messages-3359286-3.patch"
},
"drupal/simple_oauth": {
"access:false even though permission is checked for the role - https://www.drupal.org/project/simple_oauth/issues/2958159#comment-13847450": "https://www.drupal.org/files/issues/2020-10-05/simple_oauth-refresh_token_authenticated_missing_scope-2958159-4.patch",
"Allow to add multiple redirect uri for a single client - https://www.drupal.org/project/simple_oauth/issues/3331436": "https://git.drupalcode.org/project/simple_oauth/-/merge_requests/87.patch"
Expand Down
10 changes: 10 additions & 0 deletions tide_core.install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1735,3 +1735,13 @@ function tide_core_update_8076() {
$config_storage = \Drupal::service('config.storage');
$config_storage->write($view, $source->read($view));
}

/*
Copy link
Contributor

@christopher-hopper christopher-hopper May 31, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meralvingrita24
coding standards violation
pls fix

Don't forget to turn on PHPCS in your IDE with the Drupal standards at a minimum

It'll catch this stuff before you push your code.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @christopher-hopper - good day. Regarding the coding standard issue, I raised a new PR to addressed it: 810b30b

Please check and review.

* Enable path_redirect_import module.
*/
function tide_core_update_8077() {
if (!\Drupal::moduleHandler()->moduleExists('path_redirect_import')) {
$module_installer = \Drupal::service('module_installer');
$module_installer->install(['path_redirect_import']);
}
}