[SDPAP-7604] Add Redirect bulk import feature #404
Conversation
…cting 1. Initial commit for adding and installing path redirect import (https://www.drupal.org/project/issues/path_redirect_import) module for doing bulk url redirecting via CSV import
|
We should make a few changes to our Drupal issue queue patch. Remove the if/else wrapping of existing validations and only add the check you want to happen before existing validations. If you want to exit the validations early, then try using a The aim is to keep our patch change as minimal as possible to achieve the result we want. |
|
@meralvingrita24 is there a place in this module, where we can add the example "CSV" file as a template for bulk import of URL Redirects. Suggest adding some minimal documentation into the README file or somewhere appropriate. |
|
Hello @christopher-hopper , as discussed, the patch has been updated with a simplified condition to handle warning messages. As well, here is a screenshot of the instructions that has been in the module, which serves as a guide for CSV patterns.
Please let me know your thoughts here. |
christopher-hopper
changed the title
…rt-module # Conflicts: # tide_core.install Resolving tide_core.install conflict
|
Resolved merge conflict from tide_core.install |
tide_core.install
Outdated
| @@ -1735,3 +1735,13 @@ function tide_core_update_8076() { | |||
| $config_storage = \Drupal::service('config.storage'); | |||
| $config_storage->write($view, $source->read($view)); | |||
| } | |||
|
|
|||
| /* | |||
There was a problem hiding this comment.
@meralvingrita24
coding standards violation
pls fix
Don't forget to turn on PHPCS in your IDE with the Drupal standards at a minimum
- https://www.jetbrains.com/help/idea/using-php-code-sniffer.html#configure-tool-options
- https://marketplace.visualstudio.com/items?itemName=obliviousharmony.vscode-php-codesniffer
It'll catch this stuff before you push your code.
There was a problem hiding this comment.
Hello @christopher-hopper - good day. Regarding the coding standard issue, I raised a new PR to addressed it: 810b30b
Please check and review.
Jira
https://digital-vic.atlassian.net/browse/SDPAP-7604
Changes
Related issues
Screenshots