Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

updated the ripple regression test #1322

Merged
merged 5 commits into from
Oct 30, 2023
Merged

updated the ripple regression test #1322

merged 5 commits into from
Oct 30, 2023

Conversation

tim-yao
Copy link
Contributor

@tim-yao tim-yao commented Oct 26, 2023 •
edited
Loading

Motivation and Context

JIRA issue: https://digital-engagement.atlassian.net/browse/SDPA-

Changed

  1. Removed the backend regression
  2. Updated regression testing jobs

Screenshots

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

  • I've added relevant changes to the documentation.
  • I have added tests to cover my changes (if not applicable, please state why)
  • My change requires a template update for create-ripple-app.
  • I have added template update script for next release.

@tim-yao tim-yao requested review from MarkCalvert and klaukl October 26, 2023 00:47
@tim-yao tim-yao self-assigned this Oct 26, 2023
@MarkCalvert MarkCalvert mentioned this pull request Oct 30, 2023
Merged
@tim-yao tim-yao merged commit bccd0b9 into feature/update-pr-statuses Oct 30, 2023
15 of 16 checks passed
@tim-yao tim-yao deleted the ripple-gha-job-fix branch October 30, 2023 00:59
tim-yao added a commit that referenced this pull request Nov 13, 2023
@MarkCalvert @tim-yao
Added set_status job to update the PR with e2e status (#1321)
c1e696c 
* Added set_status job to update the PR with all of teh job statuses once completed

* Updated logic for testing

* Added `target_url` parameter to link to this workflow run

* Updated nightwatch workflow to e2e (#1320)

* Updated nightwatch workflow to e2e

* Updated test_type parameter value to e2e

* Update set_status workflow branch to main

* updated the ripple regression test (#1322)

* updated the ripple regression test

* fix

* use ubuntu runner temporarily

* add smoke to set status

* keep reference site UI consistent

* Add initial status

---------

Co-authored-by: Tim Yao <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkCalvert MarkCalvert MarkCalvert approved these changes

@klaukl klaukl Awaiting requested review from klaukl

Assignees

@tim-yao tim-yao

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tim-yao @MarkCalvert