Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added set_status job to update the PR with e2e status #1321

Merged
merged 9 commits into from
Nov 13, 2023
Merged

Added set_status job to update the PR with e2e status #1321

merged 9 commits into from
Nov 13, 2023

Conversation

MarkCalvert
Copy link
Contributor

@MarkCalvert MarkCalvert commented Oct 18, 2023 •
edited
Loading

No description provided.

@MarkCalvert MarkCalvert changed the title Added set_status job to update the PR with all of teh job statuses on… Added set_status job to update the PR with e2e status Oct 18, 2023
@MarkCalvert
Copy link
Contributor Author

@tim-yao I have added a job to update the status at the end of the workflow which will show up in the PR checks.
Please review and let me know if this is what you expected or what information must be displayed.
Screenshot 2023-10-18 at 4 40 09 PM

@tim-yao
Copy link
Contributor

tim-yao commented Oct 18, 2023

@tim-yao I have added a job to update the status at the end of the workflow which will show up in the PR checks. Please review and let me know if this is what you expected or what information must be displayed. Screenshot 2023-10-18 at 4 40 09 PM

Thanks @MarkCalvert. It looks nice. But how can we find the details from the PR status? It has no details link and is not in the PR checks.

I can see it in the repo Actions list, but there is no way to know which one is for which PR, and I think directly checking in Actions is not a proper way for users.

@MarkCalvert
Copy link
Contributor Author

@tim-yao I have updated the check to include the details link which will take you to the e2e test.
Let me know if this will fit the requirements and what the text should display in the check. eg. Should we keep the same naming convention as the other checks dpc-sdp/ripple/e2e

@tim-yao
Copy link
Contributor

tim-yao commented Oct 20, 2023

@tim-yao I have updated the check to include the details link which will take you to the e2e test. Let me know if this will fit the requirements and what the text should display in the check. eg. Should we keep the same naming convention as the other checks dpc-sdp/ripple/e2e

Nice one! It looks good to me. And keep it e2e is ok. No need to change. Thanks!

@MarkCalvert
Updated nightwatch workflow to e2e (#1320)
b407d8c 
* Updated nightwatch workflow to e2e

* Updated test_type parameter value to e2e
@MarkCalvert
Merge branch 'develop' into feature/update-pr-statuses
e2e0e09
@MarkCalvert MarkCalvert marked this pull request as ready for review October 23, 2023 22:45
@MarkCalvert MarkCalvert self-assigned this Oct 23, 2023
@MarkCalvert MarkCalvert requested a review from tim-yao October 25, 2023 23:15
@MarkCalvert
Copy link
Contributor Author

Hi @tim-yao ,
I have updated the set_status workflow branch to main.
This is now ready for your review and approval.

@tim-yao
Copy link
Contributor

tim-yao commented Oct 26, 2023

Thanks, @MarkCalvert the set status looks good to me. But I need to make some changes on the jobs.

  • remove the backend test in this workflow
  • add the right docker image tag to the test job

I will create a PR from this branch soon.

steveworley
steveworley previously approved these changes Oct 26, 2023
View reviewed changes
@MarkCalvert
Copy link
Contributor Author

@tim-yao Do we still need this PR with these changes included in this PR? #1322

@tim-yao
updated the ripple regression test (#1322)
bccd0b9 
* updated the ripple regression test

* fix

* use ubuntu runner temporarily

* add smoke to set status

* keep reference site UI consistent
@tim-yao
Copy link
Contributor

tim-yao commented Oct 30, 2023 •
edited
Loading

@tim-yao Do we still need this PR with these changes included in this PR? #1322

I have merged my PR into yours and added a initial status step as @klaukl discussed with your team.

@tim-yao
Copy link
Contributor

tim-yao commented Oct 30, 2023

@MarkCalvert the develop reference backend has a bug that caused e2e testing not to pass, I am okay to either merge it or hold it while waiting for the backend fixed.

@tim-yao
Copy link
Contributor

tim-yao commented Nov 1, 2023

Hi @MarkCalvert haven't got all the tests pass yet. Let's hold it for now and I will fix it by end of this week. Cheers!

@tim-yao tim-yao merged commit c1e696c into develop Nov 13, 2023
43 of 47 checks passed
@tim-yao tim-yao deleted the feature/update-pr-statuses branch November 13, 2023 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@steveworley steveworley steveworley approved these changes

@tim-yao tim-yao Awaiting requested review from tim-yao

Assignees

@MarkCalvert MarkCalvert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MarkCalvert @tim-yao @steveworley