Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[INTCONTRIB-187] Added check for schema property to show/hide count in exposed filters select lists. #1150

Closed
wants to merge 3 commits into from

Conversation

elNico
Copy link
Contributor

@elNico elNico commented Feb 17, 2022

Motivation and Context

JIRA issue: https://salsadigital.atlassian.net/browse/INTCONTRIB-187

Matching BE PR:

https://github.com/dpc-sdp/content-vic-gov-au/pull/1323

Changed

  1. Added a new schema property check to hide counts in filter select lists.
  2. New property is elasticsearch-aggregation-show-count

In schema:
https://github.com/salsadigitalauorg/content-collection-component/blob/master/src/validation/schema.json#L298
https://github.com/salsadigitalauorg/content-collection-component/blob/master/schema/schema.js#L544

Can be seen here:
https://salsadigitalauorg.github.io/content-collection-component/#/

Screenshots

image

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

  • I've added relevant changes to the documentation.
  • I have added tests to cover my changes (if not applicable, please state why)
  • My change requires a template update for create-ripple-app.
  • I have added template update script for next release.

@elNico elNico self-assigned this Feb 17, 2022
@elNico elNico changed the title [HEALTHTRAN-442] Added check for schema property to show/hide count in exposed filters select lists. [INTCONTRIB-187] Added check for schema property to show/hide count in exposed filters select lists. Mar 14, 2022
@dylankelly
Copy link
Contributor

this has been merged as part of #1203 and released in #1211

@dylankelly dylankelly closed this Jun 14, 2022
@dylankelly dylankelly deleted the feature/HEALTHTRAN-442-hide-counts branch June 14, 2022 04:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants