Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging up a number of content collection fixes. #1186

Closed
wants to merge 1 commit into from

Conversation

alan-cole
Copy link
Collaborator

@alan-cole alan-cole commented Apr 26, 2022

Motivation and Context

As there's been a number of fixes for the content collection front-end, spanned across 3 unique PR's, this PR is a chance to tackle implementing them into the core content collection library so they can be QA'd and merged in a single go.

JIRA issue: No ticket.

Changed

The PRs this ticket includes are:

#1118

  • Fix issue with Content Collection not using ES total objects (only worked with total numbers).
  • Display component to properly default to card. This will fix issue where if no value set, cards would not appear in a grid.
  • Implement the interface.filters.defaultStyling option to automatically set the column classes on the exposed filters.
  • Add RplMarkup support for description.

#1150

  • Added a new schema property check to hide counts in filter select lists. New property is elasticsearch-aggregation-show-count

#1176

  • Fixed internal sort and added clear hierarchy of external over internal if both set.

Test Environment: https://app.pr-1186.ripple.sdp2.sdp.vic.gov.au/

Screenshots

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Improvement/refactoring (non-breaking change that doesn't add any features but makes things better)

Checklist

  • I've added relevant changes to the documentation.
  • I have added tests to cover my changes (if not applicable, please state why)
  • My change requires a template update for create-ripple-app.
  • I have added template update script for next release.

This includes:
[INTCONTRIB-187] Added check for schema property to show/hide count in exposed filters select lists.
[INTCONTRIB-188] Fixed internal Content Collection sort.
And fixes relating to "Add new extended content collection widget".
@alan-cole alan-cole self-assigned this Apr 26, 2022
@alan-cole alan-cole requested a review from dylankelly April 26, 2022 04:16
@dylankelly
Copy link
Contributor

Sorry this has sat here so long @alan-cole. Without any tests is hard for us to know if this breaks anything and manual QA is resource intensive. We are working on some e2e tests to cover this.

@dylankelly
Copy link
Contributor

this has been merged as part of #1203 and released in #1211

@dylankelly dylankelly closed this Jun 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants