Add tests for VB runtime also fixes #5179 and uses Fluent Assertions

.editorconfig

@@ -494,7 +494,7 @@ dotnet_diagnostic.CA1070.severity = error
 # CA2016: Forward the CancellationToken parameter to methods that take one
 dotnet_diagnostic.CA2016.severity = warning
 
-# CA2020: Prevent behavioral change caused by built-in operators of IntPtr/UIntPtr 
+# CA2020: Prevent behavioral change caused by built-in operators of IntPtr/UIntPtr
 dotnet_diagnostic.CA2020.severity = warning
 
 # .NET diagnostic
@@ -595,6 +595,12 @@ visual_basic_preferred_modifier_order = Partial,Default,Private,Protected,Public
 
 dotnet_separate_import_directive_groups = false:warning
 
+# IDE0001: Simplify Names
+dotnet_diagnostic.IDE0001.severity = silent
+
+# IDE0002: Simplify Member Access
+dotnet_diagnostic.IDE0002.severity = silent
+
 # IDE0079: Remove unnecessary suppression
 dotnet_diagnostic.IDE0079.severity = none
 

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/CompilerServices/ExceptionUtils.vb

@@ -24,7 +24,8 @@ Namespace Microsoft.VisualBasic.CompilerServices
             Dim sMsg As String
 
             If hr > 0 AndAlso hr <= &HFFFFI Then
-                sMsg = GetResourceString(CType(hr, vbErrors))
+                Dim hr1 As vbErrors = CType(hr, vbErrors)
+                sMsg = Utils1.GetResourceString(hr1)
             Else
                 sMsg = ""
             End If
@@ -79,7 +80,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
         Friend Shared Function GetArgumentExceptionWithArgName(ArgumentName As String,
             ResourceID As String, ParamArray PlaceHolders() As String) As ArgumentException
 
-            Return New ArgumentException(GetResourceString(ResourceID, PlaceHolders), ArgumentName)
+            Return New ArgumentException(Utils1.GetResourceString(ResourceID, PlaceHolders), ArgumentName)
         End Function
 
         ''' <summary>
@@ -89,7 +90,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
         ''' <returns>A new instance of ArgumentNullException.</returns>
         Friend Shared Function GetArgumentNullException(ArgumentName As String) As ArgumentNullException
 
-            Return New ArgumentNullException(ArgumentName, GetResourceString(SR.General_ArgumentNullException))
+            Return New ArgumentNullException(ArgumentName, Utils1.GetResourceString(SR.General_ArgumentNullException))
         End Function
 
         ''' <summary>
@@ -102,7 +103,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
         Friend Shared Function GetArgumentNullException(ArgumentName As String,
             ResourceID As String, ParamArray PlaceHolders() As String) As ArgumentNullException
 
-            Return New ArgumentNullException(ArgumentName, GetResourceString(ResourceID, PlaceHolders))
+            Return New ArgumentNullException(ArgumentName, Utils1.GetResourceString(ResourceID, PlaceHolders))
         End Function
 
         ''' <summary>
@@ -114,7 +115,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
         Friend Shared Function GetDirectoryNotFoundException(
             ResourceID As String, ParamArray PlaceHolders() As String) As IO.DirectoryNotFoundException
 
-            Return New IO.DirectoryNotFoundException(GetResourceString(ResourceID, PlaceHolders))
+            Return New IO.DirectoryNotFoundException(Utils1.GetResourceString(ResourceID, PlaceHolders))
         End Function
 
         ''' <summary>
@@ -127,7 +128,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
         Friend Shared Function GetFileNotFoundException(FileName As String,
             ResourceID As String, ParamArray PlaceHolders() As String) As IO.FileNotFoundException
 
-            Return New IO.FileNotFoundException(GetResourceString(ResourceID, PlaceHolders), FileName)
+            Return New IO.FileNotFoundException(Utils1.GetResourceString(ResourceID, PlaceHolders), FileName)
         End Function
 
         ''' <summary>
@@ -139,7 +140,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
         Friend Shared Function GetInvalidOperationException(
             ResourceID As String, ParamArray PlaceHolders() As String) As InvalidOperationException
 
-            Return New InvalidOperationException(GetResourceString(ResourceID, PlaceHolders))
+            Return New InvalidOperationException(Utils1.GetResourceString(ResourceID, PlaceHolders))
         End Function
 
         ''' <summary>
@@ -150,7 +151,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
         ''' <returns>A new instance of IO.IOException.</returns>
         Friend Shared Function GetIOException(ResourceID As String, ParamArray PlaceHolders() As String) As IO.IOException
 
-            Return New IO.IOException(GetResourceString(ResourceID, PlaceHolders))
+            Return New IO.IOException(Utils1.GetResourceString(ResourceID, PlaceHolders))
         End Function
 
         ''' <summary>
@@ -164,7 +165,7 @@ Namespace Microsoft.VisualBasic.CompilerServices
         Friend Shared Function GetWin32Exception(
             ResourceID As String, ParamArray PlaceHolders() As String) As ComponentModel.Win32Exception
 
-            Return New ComponentModel.Win32Exception(Runtime.InteropServices.Marshal.GetLastWin32Error(), GetResourceString(ResourceID, PlaceHolders))
+            Return New ComponentModel.Win32Exception(Runtime.InteropServices.Marshal.GetLastWin32Error(), Utils1.GetResourceString(ResourceID, PlaceHolders))
         End Function
 
     End Class

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/CompilerServices/Utils.vb

@@ -6,7 +6,7 @@ Imports System.Globalization
 Namespace Microsoft.VisualBasic.CompilerServices
 
     ' Purpose: various helpers for the vb runtime functions
-    Friend NotInheritable Class Utils
+    Friend NotInheritable Class Utils1
 
         Friend Shared Function GetResourceString(ResourceId As vbErrors) As String
             Dim id As String = "ID" & CStr(ResourceId)

src/Microsoft.VisualBasic.Forms/src/Microsoft/VisualBasic/Devices/Network.vb

@@ -376,7 +376,7 @@ Namespace Microsoft.VisualBasic.Devices
 
                 'Throw if the file exists and the user doesn't want to overwrite
                 If IO.File.Exists(fullFilename) And Not overwrite Then
-                    Throw New IO.IOException(GetResourceString(SR.IO_FileExists_Path, destinationFileName))
+                    Throw New IO.IOException(Utils1.GetResourceString(SR.IO_FileExists_Path, destinationFileName))
                 End If
 
                 ' Set credentials if we have any

src/Microsoft.VisualBasic.Forms/src/Properties/AssemblyInfo.vb

@@ -0,0 +1,6 @@
+' Licensed to the .NET Foundation under one or more agreements.
+' The .NET Foundation licenses this file to you under the MIT license.
+
+Imports System.Runtime.CompilerServices
+
+<Assembly: InternalsVisibleTo("Microsoft.VisualBasic.Forms.Tests, PublicKey=002400000480000094000000060200000024000052534131000400000100010007d1fa57c4aed9f0a32e84aa0faefd0de9e8fd6aec8f87fb03766c834c99921eb23be79ad9d5dcc1dd9ad236132102900b723cf980957fc4e177108fc607774f29e8320e92ea05ece4e821c0a5efe8f1645c4c0c93c1ab99285d622caa652c1dfad63d745d6f2de5f17e5eaf0fc4963d261c8a12436518206dc093344d5ad293")>

src/Microsoft.VisualBasic.Forms/tests/UnitTests/Microsoft.VisualBasic.Forms.Tests.vbproj

@@ -4,11 +4,17 @@
     <SourceTargetFramework>$(TargetFramework)</SourceTargetFramework>
     <TargetFramework>$(TargetFramework)-windows7.0</TargetFramework>
     <DisableTransitiveFrameworkReferences>true</DisableTransitiveFrameworkReferences>
-    <RootNamespace>Microsoft.VisualBasic.Forms.Tests</RootNamespace>
+    <RootNamespace></RootNamespace>
     <LangVersion>latest</LangVersion>
     <GenerateRuntimeConfigurationFiles>true</GenerateRuntimeConfigurationFiles>
+    <OptionExplicit>On</OptionExplicit>
+    <OptionInfer>Off</OptionInfer>
+    <OptionStrict>On</OptionStrict>
+    <MyType>WindowsFormsWithCustomSubMain</MyType>
+    <UseApplicationFramework>True</UseApplicationFramework>
+    <OutputType>Library</OutputType>
   </PropertyGroup>
-  
+
   <ItemGroup>
     <ProjectReference Include="..\..\..\System.Design\src\System.Design.Facade.csproj" />
     <ProjectReference Include="..\..\..\System.Drawing\src\System.Drawing.Facade.csproj" />

src/Microsoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/AssemblyPublicKeyIsAsExpectedTest.vb

@@ -0,0 +1,28 @@
+' Licensed to the .NET Foundation under one or more agreements.
+' The .NET Foundation licenses this file to you under the MIT license.
+
+Imports System.Text
+Imports Xunit
+
+Namespace Microsoft.VisualBasic.Forms.Tests
+
+    Public Class AssemblyPublicKeyIsAsExpectedTest
+        Private Const AssemblyPK As String = "002400000480000094000000060200000024000052534131000400000100010007d1fa57c4aed9f0a32e84aa0faefd0de9e8fd6aec8f87fb03766c834c99921eb23be79ad9d5dcc1dd9ad236132102900b723cf980957fc4e177108fc607774f29e8320e92ea05ece4e821c0a5efe8f1645c4c0c93c1ab99285d622caa652c1dfad63d745d6f2de5f17e5eaf0fc4963d261c8a12436518206dc093344d5ad293"
+
+        ''' <summary>
+        '''  Test to find out a correct PublicKey in InternalsVisibleTo for assembly under test.
+        ''' </summary>
+        <WinFormsFact>
+        Public Sub AssemblyPublicKeyIsAsExpected()
+            Dim publicKey() As Byte = GetType(ControlTests).Assembly.GetName().GetPublicKey()
+            Dim sb As New StringBuilder
+            For Each [byte] As Byte In publicKey
+                sb.AppendFormat("{0:x2}", [byte])
+            Next [byte]
+
+            ' Set breakpoint here to find out what's in sb
+            Assert.Equal(AssemblyPK, sb.ToString())
+        End Sub
+
+    End Class
+End Namespace

src/Microsoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/ClipboardProxyTests.vb

@@ -0,0 +1,76 @@
+' Licensed to the .NET Foundation under one or more agreements.
+' The .NET Foundation licenses this file to you under the MIT license.
+
+Imports System.Collections.Specialized
+Imports System.IO
+Imports System.Windows.Forms
+Imports Xunit
+
+Namespace Microsoft.VisualBasic.Forms.Tests
+
+    ''' <summary>
+    '''  These are just checking the Proxy functions, the underlying functions are tested elsewhere.
+    ''' </summary>
+    <Collection("Sequential")>
+    <CollectionDefinition("Sequential", DisableParallelization:=True)>
+    Public Class ClipboardProxyTests
+
+        <WinFormsFact>
+        Public Sub ClipboardProxy_ContainsText()
+            Dim clipboardProxy As New MyServices.ClipboardProxy
+            Dim text As String = GetUniqueText()
+            clipboardProxy.SetText(text)
+            Assert.Equal(Clipboard.ContainsText, clipboardProxy.ContainsText)
+            Assert.Equal(Clipboard.ContainsText, clipboardProxy.ContainsText(TextDataFormat.Text))
+            Assert.Equal(Clipboard.ContainsData(DataFormats.Text), clipboardProxy.ContainsData(DataFormats.Text))
+            Assert.Equal(text, clipboardProxy.GetText())
+            text = GetUniqueText()
+            clipboardProxy.SetText(text, TextDataFormat.Text)
+            Assert.Equal(text, clipboardProxy.GetText(TextDataFormat.Text))
+        End Sub
+
+        <WinFormsFact>
+        Public Sub ClipboardProxy_GetAudioStream_InvokeMultipleTimes_Success()
+            Dim clipboardProxy As New MyServices.ClipboardProxy
+            Dim audioBytes As Byte() = {1, 2, 3}
+            clipboardProxy.SetAudio(audioBytes)
+            Dim result As Stream = clipboardProxy.GetAudioStream()
+            Assert.Equal(result.Length, clipboardProxy.GetAudioStream().Length)
+        End Sub
+
+        <WinFormsFact>
+        Public Sub ClipboardProxy_SetAudio_InvokeByteArray_GetReturnsExpected()
+            Dim clipboardProxy As New MyServices.ClipboardProxy
+            Dim audioBytes As Byte() = {1, 2, 3}
+            clipboardProxy.SetAudio(audioBytes)
+            Assert.True(clipboardProxy.ContainsAudio())
+            Assert.True(clipboardProxy.ContainsData(DataFormats.WaveAudio))
+            Assert.Equal(audioBytes.Length, Assert.IsType(Of MemoryStream)(Assert.IsType(Of MemoryStream)(CType(clipboardProxy.GetAudioStream(), MemoryStream))).Length)
+            Assert.Equal(audioBytes.Length, CType(clipboardProxy.GetData(DataFormats.WaveAudio), MemoryStream).Length)
+        End Sub
+
+        <WinFormsFact>
+        Public Sub ClipboardProxy_SetAudio_InvokeStream_GetReturnsExpected()
+            Dim clipboardProxy As New MyServices.ClipboardProxy
+            Dim audioBytes() As Byte = {1, 2, 3}
+            Using audioStream As New MemoryStream(audioBytes)
+                clipboardProxy.SetAudio(audioStream)
+                Assert.Equal(audioBytes.Length, Assert.IsType(Of MemoryStream)(clipboardProxy.GetAudioStream()).ToArray().Length)
+                Assert.Equal(audioBytes.Length, Assert.IsType(Of MemoryStream)(clipboardProxy.GetData(DataFormats.WaveAudio)).ToArray().Length)
+                Assert.True(clipboardProxy.ContainsAudio())
+                Assert.True(clipboardProxy.ContainsData(DataFormats.WaveAudio))
+            End Using
+        End Sub
+
+        <WinFormsFact>
+        Public Sub ClipboardProxy_SetFileDropList_Invoke_GetReturnsExpected()
+            Dim clipboardProxy As New MyServices.ClipboardProxy
+            Dim filePaths As New StringCollection From
+            {"filePath", "filePath2"}
+            clipboardProxy.SetFileDropList(filePaths)
+            Assert.True(clipboardProxy.ContainsFileDropList())
+            Assert.Equal(filePaths, clipboardProxy.GetFileDropList())
+        End Sub
+
+    End Class
+End Namespace

src/Microsoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/ComputerInfoDebugViewTests.vb

@@ -0,0 +1,32 @@
+' Licensed to the .NET Foundation under one or more agreements.
+' The .NET Foundation licenses this file to you under the MIT license.
+
+Imports Microsoft.VisualBasic.Devices
+Imports Microsoft.VisualBasic.Devices.ComputerInfo
+Imports Xunit
+
+Namespace Microsoft.VisualBasic.Forms.Tests
+
+    Public Class ComputerInfoDebugViewTests
+
+        <WinFormsFact>
+        Public Sub Memory()
+            Dim info As New ComputerInfoDebugView(New ComputerInfo)
+            If PlatformDetection.IsWindows Then
+                Assert.NotEqual(0UI, info.AvailablePhysicalMemory)
+                Assert.NotEqual(0UI, info.AvailableVirtualMemory)
+                Assert.NotEqual(0UI, info.TotalPhysicalMemory)
+                Assert.NotEqual(0UI, info.TotalVirtualMemory)
+            End If
+        End Sub
+
+        <WinFormsFact>
+        Public Sub Properties()
+            Dim info As New ComputerInfoDebugView(New ComputerInfo)
+            Assert.Equal(Globalization.CultureInfo.InstalledUICulture, info.InstalledUICulture)
+            Assert.Equal(Environment.OSVersion.Platform.ToString(), info.OSPlatform)
+            Assert.Equal(Environment.OSVersion.Version.ToString(), info.OSVersion)
+        End Sub
+
+    End Class
+End Namespace

src/Microsoft.VisualBasic.Forms/tests/UnitTests/System/Windows/Forms/ControlTests.vb

@@ -7,13 +7,21 @@ Imports Xunit
 Namespace Microsoft.VisualBasic.Forms.Tests
     Partial Public Class ControlTests
 
+        Public Shared Function FaultingFunc(a As Integer) As Integer
+            Return a \ 0
+        End Function
+
+        Public Shared Sub FaultingMethod()
+            Throw New DivideByZeroException()
+        End Sub
+
         <WinFormsFact>
         Public Sub Control_Invoke_Action_calls_correct_method()
             Using _control As New Control
                 _control.CreateControl()
 
                 Dim invoker As Action = AddressOf FaultingMethod
-                Dim exception = Assert.Throws(Of DivideByZeroException)(
+                Dim exception As Exception = Assert.Throws(Of DivideByZeroException)(
                     Sub() _control.Invoke(invoker))
 
                 '    Expecting something Like the following.
@@ -41,7 +49,7 @@ Namespace Microsoft.VisualBasic.Forms.Tests
                 _control.CreateControl()
 
                 Dim invoker As New MethodInvoker(AddressOf FaultingMethod)
-                Dim exception = Assert.Throws(Of DivideByZeroException)(
+                Dim exception As Exception = Assert.Throws(Of DivideByZeroException)(
                     Sub() _control.Invoke(invoker))
 
                 '    Expecting something Like the following.
@@ -69,9 +77,9 @@ Namespace Microsoft.VisualBasic.Forms.Tests
                 _control.CreateControl()
 
                 Dim invoker As Func(Of Integer, Integer) = AddressOf FaultingFunc
-                Dim exception = Assert.Throws(Of DivideByZeroException)(
+                Dim exception As Exception = Assert.Throws(Of DivideByZeroException)(
                     Sub()
-                        Dim result = _control.Invoke(Function() invoker(19))
+                        Dim result As Integer = _control.Invoke(Function() invoker(19))
                     End Sub)
 
                 '    Expecting something Like the following.
@@ -91,15 +99,5 @@ Namespace Microsoft.VisualBasic.Forms.Tests
             End Using
         End Sub
 
-        Public Shared Sub FaultingMethod()
-            Throw New DivideByZeroException()
-        End Sub
-
-        Public Shared Function FaultingFunc(a As Integer) As Integer
-            Return a \ 0
-        End Function
-
     End Class
-
 End Namespace
-