Visual Styles enabled or disabled, remove differentiation for border style in the left side of the row header when the style would have been set to Outset

[ricardobossan]

Fixes #5961

Proposed changes

• If DataGridView is RightToLeft, with either visual styles enabled or not, remove differentiation for border style in the left side of the row header when the style would have been set to Outset

Customer Impact

• Will be able to see left border of the row header when control is set to RightToLeft

Regression?

• No

Risk

• Minimal

Screenshots

Before

• Visual styles enabled

• Visual styles disabled

After

• Visual styles enabled

• Visual styles disabled

Test methodology

• Manual

Accessibility testing

• Accessibility insights

Test environment(s)

• dotnet 9.0.100-preview.3.24204.13

Microsoft Reviewers: Open in CodeFlow

[Tanya-Solyanik]

Please investigate the failing tests

[ricardobossan]

Please investigate the failing tests

@Tanya-Solyanik In my fix, I discovered that the transparency issue stems from the DataGridViewRow header's left border being set to Outset when RightToLeft is defined. By changing it to OutsetDouble, which matches the configuration when RightToLeft isn't chosen, the transparency problem is resolved.

However, this fix conflicts with existing tests, which expect the DataGridViewRow header's left border to be set to Outset. To ensure the integrity of the codebase, I'm considering modifying the tests to accommodate this fix.

I believe implementing this fix is crucial for resolving the reported issue and ensuring consistent behavior across different globalization settings. I'd appreciate your input on how best to proceed.

[Tanya-Solyanik]

However, this fix conflicts with existing tests, which expect the DataGridViewRow header's left border to be set to Outset. To ensure the integrity of the codebase, I'm considering modifying the tests to accommodate this fix.

I agree!

[Tanya-Solyanik]

In this image -

the column border is not visible between the column headers. Could you please open a new issue for that?

[LeafShi1]

In this image -

the column border is not visible between the column headers. Could you please open a new issue for that?

Using the same border style OutsetDouble here can resolve this issue

winforms/src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridView.cs

Lines 506 to 513 in f2118b8

	if (RightToLeftInternal)
	{
	dgvabs.LeftInternal = DataGridViewAdvancedCellBorderStyle.Outset;
	}
	else
	{
	dgvabs.LeftInternal = DataGridViewAdvancedCellBorderStyle.OutsetDouble;
	}

[ricardobossan]

In this image -

the column border is not visible between the column headers. Could you please open a new issue for that?

@Tanya-Solyanik, Leaf's suggestion fixed it:

[Tanya-Solyanik]

@ricardobossan - please investigate unit test failures

[codecov]

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes missing coverage. Please review.

Project coverage is 75.03208%. Comparing base (f53f153) to head (9bda02d).
Report is 217 commits behind head on main.

Additional details and impacted files

@@                 Coverage Diff                 @@
##                main      #11345         +/-   ##
===================================================
+ Coverage   74.29395%   75.03208%   +0.73812%     
===================================================
  Files           3026        3122         +96     
  Lines         627152      656198      +29046     
  Branches       46758       51715       +4957     
===================================================
+ Hits          465936      492359      +26423     
- Misses        157863      160436       +2573     
- Partials        3353        3403         +50     

Flag	Coverage Δ
Debug	75.03208% <83.33333%> (+0.73812%)	⬆️
integration	18.95253% <0.00000%> (+0.96238%)	⬆️
production	48.91950% <50.00000%> (+1.88922%)	⬆️
test	97.05592% <100.00000%> (+0.06824%)	⬆️
unit	45.95277% <50.00000%> (+1.94120%)	⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

[LeafShi1]

LGTM!

[Tanya-Solyanik]

@Olina-Zhang - could you please test this change when you have time?

[ricardobossan]

During the review of this PR we identified two issues when RightToLeft is set to Yes and VisualStyles is not enabled:

1. Column borders misalignment between header and body.
2. The top row header's left border disappears when there's a horizontal scrollbar and it is moved to the left.

These issues are not regressions from PR 11345. We will investigate these problems further and work towards a resolution in #11431 .

[ricardobossan]

@merriemcgaw @Tanya-Solyanik

Considering Merrie's message on #11431, where it was mentioned that we should not modify anything with VisualStyles turned off:

In this PR, I have already fixed the missing column between the row header and the DataGridView body for both VisualStyles enabled and disabled. Should I revert that change for when VisualStyles is off? I can easily revert that change without removing the fix for when VisualStyles is on.

[merriemcgaw]

@ricardobossan if you've already got the fix, then I don't mind taking it. Mostly I wanted to make sure we don't invest too much time in Visual Styles Off.

[ricardobossan]

@merriemcgaw Got it. I'll keep it then. Thank you!

[lonitra]

Changes LGTM, In regard to previous conversation:

In this image -
the column border is not visible between the column headers. Could you please open a new issue for that?

@Tanya-Solyanik, Leaf's suggestion fixed it:

It looks like we have gone with a different change in this PR than what was Leaf's suggestion, curious if this still resolves the issue Tanya pointed out here #11345 (comment)

[ricardobossan]

@lonitra Thanks! I just ran the code from this PR and the issue that Tanya mentioned in her comment is solved, as seen in the image bellow: