Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Column Borders Misalignment and Top Row Header Border Disappearance with RightToLeft and VisualStyles not Enabled #11431

Closed
ricardobossan opened this issue May 28, 2024 · 1 comment
Assignees
Labels
Milestone

Comments

@ricardobossan
Copy link
Member

ricardobossan commented May 28, 2024

.NET version

9.0.100-preview.3.24204.13

Did it work in .NET Framework?

Not tested/verified

Did it work in any of the earlier releases of .NET Core or .NET 5+?

No response

Issue description

During the review of PR 11345, we identified two issues when RightToLeft is set to Yes and VisualStyles is not enabled:

  1. Column borders misalignment between header and body;
  2. The top row header's left border disappears when there's a horizontal scrollbar and it is moved to the left.

Screenshots:

In all images:

  • VisualStyles is not enabled.
  • There's 2 DataGridView controls, for comparison purposes: the top one is RTL, the one at the bottom isn't.

1. Column borders misalignment between header and body

The problem only happens on RTL and when VisualStyles is not enabled:

100% Zoom:

misaligned_visualstyles_off_zoom_100

400 Zoom:

misaligned_visualstyles_off_zoom_400

2. The top row header's left border disappears when there's a horizontal scrollbar and it is moved to the left

The problem only happens on RTL and when VisualStyles is not enabled.

disapearing_border_on_scroll

3. Also, @Olina-Zhang noticed gaps between row and column lines in the headers and row headers when VisualStyles is not enabled

@Tanya-Solyanik , I don't know if this problem should be addressed in this issue because:

  • It is barely visible at 100% Zoom;
  • It happens wheter RTL is Yes or No, so I wonder if those gaps exist by design.

100% Zoom:

visualstyles_off_zoom_100

400% Zoom:

visualstyles_off_zoom_400

These issues are not regressions from PR 11345. We are opening this new issue to track the column borders misalignment and the top row header border issue.

We will investigate these problems further and work towards a resolution in this new issue.

Steps to reproduce

Create a new DataGridView form and set it to RightToLeft.Yes and do not enable VisualStyles. Sample project here.

@ricardobossan ricardobossan added the untriaged The team needs to look at this issue in the next triage label May 28, 2024
@ricardobossan ricardobossan added 🚧 work in progress Work that is current in progress and removed untriaged The team needs to look at this issue in the next triage labels May 28, 2024
@ricardobossan ricardobossan self-assigned this May 28, 2024
@ricardobossan ricardobossan added the 🪲 bug Product bug (most likely) label May 28, 2024
@LeafShi1 LeafShi1 added this to the .NET 9.0 milestone May 29, 2024
@Tanya-Solyanik Tanya-Solyanik added the 📭 waiting-author-feedback The team requires more information from the author label May 29, 2024
@ricardobossan ricardobossan added untriaged The team needs to look at this issue in the next triage and removed 🚧 work in progress Work that is current in progress labels May 29, 2024
@merriemcgaw
Copy link
Member

We should not be making changes to anything with Visual Styles turned off.

@dotnet-policy-service dotnet-policy-service bot removed untriaged The team needs to look at this issue in the next triage 📭 waiting-author-feedback The team requires more information from the author labels May 30, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

5 participants