Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Row header border line of the DataGridView control has very low luminosity contrast ratio #5961

Open
SergeySmirnov-Akvelon opened this issue Oct 13, 2021 · 5 comments · Fixed by #11345 · May be fixed by #12210
Open

Row header border line of the DataGridView control has very low luminosity contrast ratio #5961

SergeySmirnov-Akvelon opened this issue Oct 13, 2021 · 5 comments · Fixed by #11345 · May be fixed by #12210
Assignees
@ricardobossan @Epica3055
Labels
🪲 bug Product bug (most likely) 🚧 work in progress Work that is current in progress tenet-accessibility MAS violation, UIA issue; problems with accessibility standards
Milestone
10.0 Preview1

Comments

@SergeySmirnov-Akvelon
Copy link
Contributor

.NET Core Version:

  • .NET Core SDK: 7.0.0-alpha.1.21512.1

Have you experienced this same bug with .NET Framework?:

  • Yes

Repro steps:

  1. Create a Form with a DataGridView.
  2. Add multiple columns to a DataGridView.
  3. Add several rows to the DataGridView.
  4. Set DataGridView.RightToLeft = RightToLefYes
  5. Run the application.

Actual behavior:
Row header border line of the DataGridView control has very low luminosity contrast ratio.

RightToLeft = Yes:
image

RightToLeft = No:
image

Expected behavior:
Luminosity contrast ratio of the row header border line of the DataGridView control should be greater than 3:1.
@vladimir-krestov vladimir-krestov added the tenet-accessibility MAS violation, UIA issue; problems with accessibility standards label Sep 9, 2022
@Tanya-Solyanik Tanya-Solyanik added this to the Future milestone Jul 18, 2023
@elachlan
Copy link
Contributor

elachlan commented Jan 6, 2024

@Olina-Zhang I think this might have been resolved in another issue/pr. Can your team please re-test?

@Olina-Zhang
Copy link
Member

It still repro in the latest .Net 9.0 SDK build: 9.0.100-alpha.1.24053.14.
image

@elachlan elachlan added the 🪲 bug Product bug (most likely) label Jan 8, 2024
@Tanya-Solyanik Tanya-Solyanik modified the milestones: Future, .NET 9.0 Jan 8, 2024
@ricardobossan ricardobossan mentioned this issue May 9, 2024
Merged
@dotnet-policy-service dotnet-policy-service bot added the 🚧 work in progress Work that is current in progress label May 9, 2024
@JeremyKuhne JeremyKuhne modified the milestones: .NET 9.0, 9.0 RC1 Jul 24, 2024
@Olina-Zhang
Copy link
Member

Olina-Zhang commented Aug 8, 2024 •
edited
Loading

Verified this issue in the latest .NET 9.0 RC1 build: 9.0.100-rc.1.24407.28, it was fixed:
image

@Olina-Zhang
Copy link
Member

Verified it with .NET 9.0.100-rc.1.24422.10 test pass build that the issue has been fixed, which have the same results as above.

@github-actions github-actions bot locked and limited conversation to collaborators Sep 28, 2024
@Tanya-Solyanik
Copy link
Member

Tanya-Solyanik commented Oct 1, 2024 •
edited
Loading

Reverted this fix - #12246 due to a regression when GridColor is set to a custom color and incompleteness of this fix - RightToLeft.No layout produces row headers border that it not contrasting enough too.
image

@Tanya-Solyanik Tanya-Solyanik reopened this Oct 1, 2024
@Tanya-Solyanik Tanya-Solyanik changed the title Row header border line of the DataGridView control has very low luminosity contrast ratio when "RightToLeft = Yes" Row header border line of the DataGridView control has very low luminosity contrast ratio Oct 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ricardobossan ricardobossan

@Epica3055 Epica3055

Labels
🪲 bug Product bug (most likely) 🚧 work in progress Work that is current in progress tenet-accessibility MAS violation, UIA issue; problems with accessibility standards
Projects
None yet
Milestone
10.0 Preview1
8 participants
@elachlan @JeremyKuhne @Tanya-Solyanik @SergeySmirnov-Akvelon @Olina-Zhang @ricardobossan @vladimir-krestov @Epica3055