Fix issue 12187 Extra Border Color in DataGridView with RightToLeft. #12210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #12210 +/- ##
===================================================
+ Coverage 75.16050% 75.39022% +0.22972%
===================================================
Files 3070 3100 +30
Lines 632557 634378 +1821
Branches 46787 46865 +78
===================================================
+ Hits 475433 478259 +2826
+ Misses 153740 152710 -1030
- Partials 3384 3409 +25
Flags with carried forward coverage won't be shown. Click here to find out more. |
LeafShi1
reviewed
Sep 24, 2024
ricardobossan
added
the
waiting-review
|
I agree with Leaf, this should be tested thoroughly. @Syareel-Sukeri - could you please test the PR? |
src/System.Windows.Forms/src/System/Windows/Forms/Controls/DataGridView/DataGridViewRow.cs
Outdated
Show resolved
Hide resolved
Tanya-Solyanik
added
📬 waiting-for-testing
Epica3055
added
waiting-review
LeafShi1
approved these changes
Sep 30, 2024
|
@Epica3055 This PR changes cell size compared to NET8. Could you please investigate if we can adjust color value here or elsewhere - |
Tanya-Solyanik
added
📭 waiting-author-feedback
Epica3055
force-pushed
the
Fix_Issue_12187
branch
from
e3ea34c
to
f7107b4
Compare
dotnet-policy-service
bot
removed
the
📭 waiting-author-feedback
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5961
Proposed changes
Regression?
Screenshots
Before
After
When no color applied
Test methodology
Test environment(s)
Microsoft Reviewers: Open in CodeFlow