Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump NuGet.Protocol from 6.6.0 to 6.6.1 in /eng/dependabot #6758

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Jun 19, 2023

Bumps NuGet.Protocol from 6.6.0 to 6.6.1.

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [NuGet.Protocol](https://github.com/NuGet/NuGet.Client) from 6.6.0 to 6.6.1.
- [Release notes](https://github.com/NuGet/NuGet.Client/releases)
- [Commits](https://github.com/NuGet/NuGet.Client/commits)

---
updated-dependencies:
- dependency-name: NuGet.Protocol
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested review from a team and GangWang01 as code owners June 19, 2023 01:59
@dependabot dependabot bot added dependabot: main dependencies Pull requests that update a dependency file labels Jun 19, 2023
@YuliiaKovalova YuliiaKovalova added the impeded The issue is impeded by the issue\missing functionality of different product. label Jun 19, 2023
@joeloff
Copy link
Member

joeloff commented Jun 29, 2023

working on updating Source Build

@mthalman
Copy link
Member

Updating SBRP isn't going to fix this. The error is for a package downgrade.

The project is referencing NuGet.Protocol.6.6.1, which has a transitive dependency to NuGet.Configuration.6.6.1. But the project also references NuGet.Configuration.6.6.0 which causes the downgrade. So the fix should be to either remove the explicit reference to NuGet.Configuration.6.6.0 or upgrade it to NuGet.Configuration.6.6.1.

@marcpopMSFT
Copy link
Member

@mthalman after updating all three nuget packages together, we're now getting SB errors which may require the change Jacques has linked to:

.packages/microsoft.dotnet.arcade.sdk/8.0.0-beta.23329.1/tools/SourceBuild/AfterSourceBuild.proj(68,5): error : (NETCORE_ENGINEERING_TELEMETRY=AfterSourceBuild) 4 new pre-builts discovered! Detailed usage report can be found at /__w/1/s/artifacts/source-build/self/prebuilt-report/baseline-comparison.xml.
See https://aka.ms/dotnet/prebuilts for guidance on what pre-builts are and how to eliminate them.

@mthalman
Copy link
Member

@mthalman Matt Thalman FTE after updating all three nuget packages together, we're now getting SB errors which may require the change Jacques has linked to:

Ah, right. Sounds good then. I've approved dotnet/source-build-reference-packages#733.

@joeloff joeloff merged commit 85d7ad4 into main Jul 1, 2023
@dependabot dependabot bot deleted the dependabot/nuget/eng/dependabot/main/NuGet.Protocol-6.6.1 branch July 1, 2023 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependabot: main dependencies Pull requests that update a dependency file impeded The issue is impeded by the issue\missing functionality of different product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants