Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional NuGet packages for 6.6.1 #733

Merged
merged 2 commits into from
Jun 30, 2023
Merged

Add additional NuGet packages for 6.6.1 #733

merged 2 commits into from
Jun 30, 2023

Conversation

joeloff
Copy link
Member

@joeloff joeloff commented Jun 29, 2023 •
edited by mthalman
Loading

Additional templating PRs are failing

dotnet/templating#6758
dotnet/templating#6752

Adds:

  • NuGet.Versioning.6.6.1
  • NuGet.Packaging.6.6.1
  • NuGet.Protocol.6.6.1
  • NuGet.Credentials.6.6.1

@joeloff joeloff marked this pull request as ready for review June 29, 2023 23:32
@mthalman
Copy link
Member

I don't think these changes are necessary. See dotnet/templating#6758 (comment)

@mthalman
Copy link
Member

I don't think these changes are necessary. See dotnet/templating#6758 (comment)

Package downgrade issues have been resolved and reveals the need to still have these defined.

@mthalman mthalman enabled auto-merge (squash) June 30, 2023 17:27
@mthalman mthalman mentioned this pull request Jun 30, 2023
Merged
@mthalman mthalman merged commit c7e229b into dotnet:main Jun 30, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mthalman mthalman mthalman approved these changes

@MichaelSimons MichaelSimons Awaiting requested review from MichaelSimons

@oleksandr-didyk oleksandr-didyk Awaiting requested review from oleksandr-didyk

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@joeloff @mthalman