Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[main] Update dependencies from dotnet/arcade #82599

Merged
merged 4 commits into from
Feb 28, 2023
Merged

[main] Update dependencies from dotnet/arcade #82599

merged 4 commits into from
Feb 28, 2023

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Feb 24, 2023 •
edited
Loading

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230223.2
  • Date Produced: February 23, 2023 10:31:41 PM UTC
  • Commit: 39952f0f2dbd76699158d5f84fc3644602ad08c9
  • Branch: refs/heads/main

@dotnet-maestro
Update dependencies from https://github.com/dotnet/arcade build 20230…
f9b3de7 
…223.2

Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Archives , Microsoft.DotNet.Build.Tasks.Feed , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Build.Tasks.Packaging , Microsoft.DotNet.Build.Tasks.TargetFramework , Microsoft.DotNet.Build.Tasks.Templating , Microsoft.DotNet.Build.Tasks.Workloads , Microsoft.DotNet.CodeAnalysis , Microsoft.DotNet.GenAPI , Microsoft.DotNet.GenFacades , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.PackageTesting , Microsoft.DotNet.RemoteExecutor , Microsoft.DotNet.SharedFramework.Sdk , Microsoft.DotNet.VersionTools.Tasks , Microsoft.DotNet.XUnitConsoleRunner , Microsoft.DotNet.XUnitExtensions
 From Version 8.0.0-beta.23120.1 -> To Version 8.0.0-beta.23123.2
This was referenced Feb 24, 2023
Closed
Closed
@ericstj
Copy link
Member

ericstj commented Feb 24, 2023

Looks like this one is seeing the breaking changes from fix for #80581. cc @VSadov @rainersigwald

@lewing lewing added the area-codeflow for labeling automated codeflow label Feb 24, 2023
@lewing
Copy link
Member

lewing commented Feb 24, 2023

@thaystg can you take a look at the debugger failure

@lewing lewing mentioned this pull request Feb 25, 2023
Closed
@hoyosjs hoyosjs linked an issue Feb 25, 2023 that may be closed by this pull request
Library and Tools Subset build times regression (50+% increase) #82583
Closed
@lewing
Copy link
Member

lewing commented Feb 25, 2023 •
edited
Loading

still a few arch failures, we can disable the debugger test if it ends up being the blocking issue

@lewing lewing added the area-HostModel Microsoft.NET.HostModel issues label Feb 26, 2023
@ghost
Copy link

ghost commented Feb 26, 2023

Tagging subscribers to this area: @vitek-karas, @agocke
See info in area-owners.md if you want to be subscribed.

Issue Details

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: c32383ee-d79c-4435-5b63-08d8d8feb47e
  • Build: 20230223.2
  • Date Produced: February 23, 2023 10:31:41 PM UTC
  • Commit: 39952f0f2dbd76699158d5f84fc3644602ad08c9
  • Branch: refs/heads/main
Author: dotnet-maestro[bot]
Assignees: -
Labels:

area-HostModel, area-codeflow
Milestone: -

@lewing
Copy link
Member

lewing commented Feb 26, 2023 

The command error output did not contain expected result: 'System.IO.FileNotFoundException: Could not load file or assembly 'Newtonsoft.Json'
File Name: /__w/1/s/artifacts/tests/Release/ha/sharedFrameworkPublish/dotnet
Arguments: /__w/1/s/artifacts/tests/Release/ha/g0dlf5bw.ayb/PortableAppWithException/bin/PortableAppWithException.dll
Exit Code: 134
StdOut:
Hello from startup hook with dependency!
Hello World!

StdErr:
Unhandled exception. System.Exception: Goodbye World!
at PortableAppWithException.Program.Main(String[] args) in /__w/1/s/artifacts/tests/Release/ha/yyfvmkyc.rsc/PortableAppWithException/Program.cs:line 15


Stack trace
   at FluentAssertions.Execution.XUnit2TestFramework.Throw(String message)
   at FluentAssertions.Execution.TestFrameworkProvider.Throw(String message)
   at FluentAssertions.Execution.DefaultAssertionStrategy.HandleFailure(String message)
   at FluentAssertions.Execution.AssertionScope.FailWith(Func`1 failReasonFunc)
   at Microsoft.DotNet.CoreSetup.Test.CommandResultAssertions.HaveStdErrContaining(String pattern) in /_/src/installer/tests/TestUtils/Assertions/CommandResultAssertions.cs:line 86
   at Microsoft.DotNet.CoreSetup.Test.HostActivation.StartupHooks.Muxer_activation_of_StartupHook_With_Missing_Dependencies_Fails() in /_/src/installer/tests/HostActivation.Tests/StartupHooks.cs:line 195
   at System.RuntimeMethodHandle.InvokeMethod(Object target, Void** arguments, Signature sig, Boolean isConstructor)
   at System.Reflection.MethodInvoker.Invoke(Object obj, IntPtr* args, BindingFlags invokeAttr)

@thaystg thaystg mentioned this pull request Feb 27, 2023
Merged
@elinor-fung
Copy link
Member

The host test failures are from the way they test some moving/configuring dependencies. I suspect it is related to publish defaulting to Release - the test's attempt to use the missing dependency is probably optimized out. Long term, we intend to rework those tests so that they shouldn't be affected by SDK changes like this: #77807 (comment), #77805.

I'll look at fixing the affected tests for this particular change.

@jaredpar jaredpar mentioned this pull request Feb 28, 2023
Closed
@marek-safar marek-safar merged commit 1600876 into main Feb 28, 2023
@marek-safar marek-safar deleted the darc-main-e638dc2b-c801-4bc5-9763-98d13f317a42 branch February 28, 2023 09:01
@elinor-fung elinor-fung mentioned this pull request Mar 15, 2023
Merged
@ghost ghost locked as resolved and limited conversation to collaborators Mar 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

Assignees
No one assigned
Labels
area-codeflow for labeling automated codeflow area-HostModel Microsoft.NET.HostModel issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Library and Tools Subset build times regression (50+% increase)
5 participants
@ericstj @lewing @elinor-fung @jkoritzinsky @marek-safar