-
Notifications
You must be signed in to change notification settings - Fork 4.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update SDK to preview 1 #82652
Update SDK to preview 1 #82652
Conversation
I think you're likely blocked from upgrading Roslyn until the following issues are addressed:
@lewing as he was tracking the new roslyn insertion |
we ifdefed the parameter test for the moment but I don't think we should update roslyn again unless we have reason to believe #82467 has been resolved |
2951f81
to
334a778
Compare
needs the fixes in #82599 and whatever is missing (we should probably just take the arcade bump) |
Closing in favor of that one. The upgrade already happens there anyway. |
Fixes #82583
The slowdowns was being caused by a crash in VBCSCompiler. The process was resilient
to these crashes, but the cached state gets destroyed and the slowness was a
symptom. The crash was when trying to destroy thread statics of dynamic classes
on a collectible module for a thread destroy path. To do this, it checks all
the dynamic entries in the TLM and frees both GC and non-GC statics. The SDK
currently being used doesn't contain #80822 which 0-initializes the entry.
Without this, we try to free a static that doesn't exist and we crash.