Fix reporting of MSBuild warnings in MSBuildWorkspace

src/Workspaces/Core/MSBuild/MSBuild/DiagnosticReporter.cs

@@ -58,13 +58,25 @@ public void Report(IEnumerable<DiagnosticLogItem> log)
         {
             foreach (var logItem in log)
             {
-                Report(DiagnosticReportingMode.Log, GetMSBuildFailedMessage(logItem.ProjectFilePath, logItem.ToString()));
+                var diagnosticKind = logItem.Kind is DiagnosticLogItemKind.Warning ? WorkspaceDiagnosticKind.Warning : WorkspaceDiagnosticKind.Failure;
+
+                Report(new WorkspaceDiagnostic(diagnosticKind, GetMSBuildFailedMessage(logItem.ProjectFilePath, logItem.ToString(), diagnosticKind)));
             }
         }
 
-        private static string GetMSBuildFailedMessage(string projectFilePath, string message)
-            => RoslynString.IsNullOrWhiteSpace(message)
-                ? string.Format(WorkspaceMSBuildResources.Msbuild_failed_when_processing_the_file_0, projectFilePath)
-                : string.Format(WorkspaceMSBuildResources.Msbuild_failed_when_processing_the_file_0_with_message_1, projectFilePath, message);
+        private static string GetMSBuildFailedMessage(string projectFilePath, string message, WorkspaceDiagnosticKind diagnosticKind)
+        {
+            if (RoslynString.IsNullOrWhiteSpace(message))
+            {
+                message = WorkspaceMSBuildResources.No_message;
+            }
+
+            return string.Format(
+                diagnosticKind == WorkspaceDiagnosticKind.Warning
+                    ? WorkspaceMSBuildResources.Msbuild_warned_when_processing_the_file_0_with_message_1
+                    : WorkspaceMSBuildResources.Msbuild_failed_when_processing_the_file_0_with_message_1,
+                projectFilePath,
+                message);
+        }
     }
 }

src/Workspaces/Core/MSBuild/WorkspaceMSBuildResources.resx

@@ -132,11 +132,14 @@
   <data name="Invalid_0_specified_1" xml:space="preserve">
     <value>Invalid {0} specified: {1}</value>
   </data>
-  <data name="Msbuild_failed_when_processing_the_file_0" xml:space="preserve">
-    <value>Msbuild failed when processing the file '{0}'</value>
-  </data>
   <data name="Msbuild_failed_when_processing_the_file_0_with_message_1" xml:space="preserve">
-    <value>Msbuild failed when processing the file '{0}' with message: {1}</value>
+    <value>MSBuild failed when processing the file '{0}' with message: {1}</value>
+  </data>
+  <data name="Msbuild_warned_when_processing_the_file_0_with_message_1" xml:space="preserve">
+    <value>MSBuild warned when processing the file '{0}' with message: {1}</value>
+  </data>
+  <data name="No_message" xml:space="preserve">
+    <value>No message</value>
   </data>
   <data name="Path_for_document_0_was_null" xml:space="preserve">
     <value>Path for document '{0}' was null</value>