Fix reporting of MSBuild warnings in MSBuildWorkspace #75183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-IDE
untriaged
dotnet-policy-service
bot
added
Community
jasonmalinowski
approved these changes
Sep 20, 2024
| } | ||
| } | ||
|
|
||
| private static string GetMSBuildFailedMessage(string projectFilePath, string message) | ||
| private static string GetMSBuildFailedMessage(string projectFilePath, string message, WorkspaceDiagnosticKind diagnosticKind) | ||
| => RoslynString.IsNullOrWhiteSpace(message) |
There was a problem hiding this comment.
It might just be easier to fill in a blank message with "no message" or something so the log entry would be a bit clearer we're missing one (and it reduces the number of strings we have). That said, happy to keep this as is since you're just maintaining behavior.
There was a problem hiding this comment.
I have made the change.
JoeRobich
reviewed
Sep 20, 2024
| <value>MSBuild failed when processing the file '{0}' with message: {1}</value> | ||
| </data> | ||
| <data name="Msbuild_warning_when_processing_the_file_0" xml:space="preserve"> | ||
| <value>MSBuild warning when processing the file '{0}'</value> |
There was a problem hiding this comment.
I think we should change this string to MSBuild warned ... to keep it in line with the MSBuild failed ... string.
|
Will this change fix #75170? |
|
@tmat I'm not sure, but probably not. If the issues are originally reported as warnings, then this PR will make sure they will end up as warnings. Otherwise, it won't change anything. |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #75182