Measure invalidation performance and fixes (batching version) #24823

albyrock87 · 2024-09-18T18:43:07Z

Description of Change

This is #24532 plus batching of measure invalidation.

I executed a speedscope on davidortinau/AllTheLists LearningPage using the latest nightly 8.0.99-ci.net8.24468.1 build.

What I noticed is that #23052 OnChildMeasureInvalidatedInternal was showing up and taking 2% of total time (recursive calls).

What I've done:

Highly increases general performance when changing BindingContext on attached nodes by batching layout invalidation during binding context change & propagation
- This is covered by a new suite of unit tests
- This makes finally predictable the layout invalidation when BindingContext changes, from the leaf to the root
Avoids triggering measure invalidated completely while building the MAUI tree in memory (Handler = null)
Fixes some iOS SetNeedsLayout propagation issues and cleans up detection of auto SetNeedsLayout parent propagation with IPropagatesSetNeedsLayout internal interface
Removes "out-of-layout-pass" measurements from legacy layouts making them fast as new layouts

WinUI Speedscope

Kindly provided by @MartyIX

Before main

1726728202.MAIN.speedscope.json

After PR

1726728309.PR.speedscope.json

Before main

1726728235.MAIN.speedscope.json

After PR

1726728360.PR.speedscope.json

Android Speedscope

Before main

android-before.speedscope.json

After PR

after-android.speedscope.json.zip

iOS Speedscope

Before main

before.speedscope.json.zip

After PR

after.speedscope.json.zip

Before main

You can notice there are some hiccups while scrolling.

before.mp4

After PR

You can notice there hiccups are basically gone while scrolling, even if in this case I had a lot more nested children.

after.mp4

Issues Fixed

Fixes #24551

albyrock87 · 2024-09-18T18:51:28Z

src/Controls/tests/DeviceTests/Elements/View/ViewTests.cs

+				frame = control.Frame;
+				desiredSize = control.DesiredSize;
+				Assert.Equal(5, frame.X, 0.5d);
+				Assert.Equal(60, frame.Width, 0.5d);


This was failing on ListView and TableView due to the fact they were not propagating SetNeedsLayout to the parent.

OvrBtn · 2024-09-18T18:55:08Z

Thank you so much for your work, can't wait to try it out!

Do you think or have you tested if it will also affect performance of rendering pages when navigating/performing first render? Currently navigation can be a lot slower than Xamarin in certain cases, sometimes even with static pages without binding and collections.

albyrock87 · 2024-09-18T18:58:49Z

@OvrBtn it improves that a bit if you're using ContentView or legacy layouts.
I have other ideas to improve that scenario, but I didn't want to increase an already big PR.

PureWeen · 2024-09-18T19:19:46Z

/azp run

azure-pipelines · 2024-09-18T19:20:06Z

Azure Pipelines successfully started running 3 pipeline(s).

bcaceiro · 2024-09-18T20:17:51Z

@albyrock87 great work! What about android, which seems to be the slowest platform overall so far in .net maui, have you seen even bigger improvements?

albyrock87 · 2024-09-20T10:20:33Z

@bcaceiro I'm not sure how, but in this CollectionView-related test, Android seems very fast compared to iOS and in fact I'm not able to see relevant differences (I've added speedscopes above).
I remember Android being very slow too, so I'm under the impression that latest service releases brought major improvements on that platform.

albyrock87 · 2024-09-20T10:31:06Z

src/Controls/src/Core/Internals/InvalidationTriggerFlags.cs

+namespace Microsoft.Maui.Controls.Internals;
+
+[Flags]
+internal enum InvalidationTriggerFlags : ushort


InvalidationTrigger is a public API but at the same time it says

For internal use by platform renderers.

So I wonder if I could simply change that to:

[Flags] public enum InvalidationTrigger : ushort { None = 0, BatchingBindingContext = 1 << 0, // leaving empty space here in case we want to add other types of batching NotifyOnChildMeasureInvalidated = 1 << 4, HorizontalOptionsChanged = 1 << 5, VerticalOptionsChanged = 1 << 6, MarginChanged = 1 << 7, SizeRequestChanged = 1 << 8, MeasureChanged = 1 << 9, RendererReady = 1 << 10, Undefined = 1 << 11, }

PureWeen · 2024-10-18T20:35:28Z

/azp run

azure-pipelines · 2024-10-18T20:35:50Z

Azure Pipelines successfully started running 3 pipeline(s).

albyrock87 · 2024-10-19T09:41:08Z

iOS failing tests are related to CollectionViewHandler2
@PureWeen may you rerun only failed Jobs on other platforms?

jsuarezruiz · 2024-10-30T07:07:46Z

/rebase

jsuarezruiz · 2024-10-30T07:08:46Z

/azp run

azure-pipelines · 2024-10-30T07:09:07Z

Azure Pipelines successfully started running 3 pipeline(s).

PureWeen · 2024-11-01T16:15:15Z

/rebase

- Do not bubble up `MeasureInvalidated` on pages - Invoke `MeasureInvalidated` just once when `BindingContext` is changing - Do not synchronously measure/arrange children on legacy layout upon child measure invalidated: simply wait for the next native layout pass

… switch branches

…parent correctly

…e to invalidate parent chain through the platform view on `ScrollView` (iOS)

albyrock87 · 2024-11-06T14:04:15Z

Closing in favor of #25664

albyrock87 requested a review from a team as a code owner September 18, 2024 18:43

albyrock87 requested review from StephaneDelcroix and tj-devel709 September 18, 2024 18:43

dotnet-policy-service bot added the community ✨ Community Contribution label Sep 18, 2024

albyrock87 commented Sep 18, 2024

View reviewed changes

albyrock87 changed the title ~~Measure invalidation performance and fixes~~ Measure invalidation performance and fixes (batching version) Sep 18, 2024

albyrock87 commented Sep 20, 2024

View reviewed changes

rmarinho requested review from jonathanpeppers and PureWeen and removed request for tj-devel709 September 24, 2024 11:15

filipnavara mentioned this pull request Oct 16, 2024

Revert PR #23052 behavior under new app context switch #25324

Closed

albyrock87 force-pushed the improve-measure-invalidation-with-batch-measure-invalidation branch 2 times, most recently from bef003d to 4429238 Compare October 18, 2024 20:32

albyrock87 added a commit to nalu-development/maui-custom that referenced this pull request Oct 19, 2024

Measure invalidation performance and fixes (dotnet#24823)

d73fa74

albyrock87 added a commit to nalu-development/maui-custom that referenced this pull request Oct 19, 2024

Measure invalidation performance and fixes (dotnet#24823)

7955f00

jsuarezruiz added the t/perf The issue affects performance (runtime speed, memory usage, startup time, etc.) (sub: perf) label Oct 30, 2024

github-actions bot force-pushed the improve-measure-invalidation-with-batch-measure-invalidation branch from 4429238 to c0057a0 Compare October 30, 2024 07:08

PureWeen mentioned this pull request Oct 30, 2024

[Testing] Add AllLists Sample to Manual Testing to validate performance expectations #25609

Open

PureWeen mentioned this pull request Oct 30, 2024

Revert PR #23052 behavior under new app context switch #25613

Merged

PureWeen added the do-not-merge Don't merge this PR label Oct 31, 2024

albyrock87 and others added 18 commits November 1, 2024 16:15

Add a UI test to log rendering performance

706eec8

Remove ApplyBindings and reduce OnChildMeasureInvalidatedInternal…

7491dfa

… switch branches

Update Issue24532.xaml.cs

00138ad

Account for view Constraint and propagate InvalidationTrigger on …

a355ff9

…parent correctly

Now that we are not invalidating manually each LegacyLayout, we hav…

28c806d

…e to invalidate parent chain through the platform view on `ScrollView` (iOS)

Sync behavior on Page

9352b1d

Removes old perf test

aafcdf7

Adds a rendering performance test

4bb7d77

Additional refactor

201e52c

Removes performance test

af89144

Remove old comments

3daf40f

Remove useless branches and fix order of invocation

21b2607

Fix broken device test

c124862

Third tentative to make things right

bc44d29

Cleanup and fix enhanced ViewTests broken device test

81032ba

Batch measure invalidation on binding context changed

49f5afe

Fix rebase errors

4c07e48

github-actions bot force-pushed the improve-measure-invalidation-with-batch-measure-invalidation branch from c0057a0 to 4c07e48 Compare November 1, 2024 16:15

Tamilarasan-Paranthaman mentioned this pull request Nov 5, 2024

[Windows] Fix for the screen does not display when changing the CurrentPage of a TabbedPage #25690

Closed

4 tasks

albyrock87 closed this Nov 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Measure invalidation performance and fixes (batching version) #24823

Measure invalidation performance and fixes (batching version) #24823

albyrock87 commented Sep 18, 2024 •

edited

Loading

albyrock87 Sep 18, 2024

OvrBtn commented Sep 18, 2024

albyrock87 commented Sep 18, 2024

PureWeen commented Sep 18, 2024

azure-pipelines bot commented Sep 18, 2024

bcaceiro commented Sep 18, 2024

albyrock87 commented Sep 20, 2024 •

edited

Loading

albyrock87 Sep 20, 2024

PureWeen commented Oct 18, 2024

azure-pipelines bot commented Oct 18, 2024

albyrock87 commented Oct 19, 2024

jsuarezruiz commented Oct 30, 2024

jsuarezruiz commented Oct 30, 2024

azure-pipelines bot commented Oct 30, 2024

PureWeen commented Nov 1, 2024

albyrock87 commented Nov 6, 2024

Measure invalidation performance and fixes (batching version) #24823

Measure invalidation performance and fixes (batching version) #24823

Conversation

albyrock87 commented Sep 18, 2024 • edited Loading

Description of Change

WinUI Speedscope

Android Speedscope

iOS Speedscope

Issues Fixed

albyrock87 Sep 18, 2024

Choose a reason for hiding this comment

OvrBtn commented Sep 18, 2024

albyrock87 commented Sep 18, 2024

PureWeen commented Sep 18, 2024

azure-pipelines bot commented Sep 18, 2024

bcaceiro commented Sep 18, 2024

albyrock87 commented Sep 20, 2024 • edited Loading

albyrock87 Sep 20, 2024

Choose a reason for hiding this comment

PureWeen commented Oct 18, 2024

azure-pipelines bot commented Oct 18, 2024

albyrock87 commented Oct 19, 2024

jsuarezruiz commented Oct 30, 2024

jsuarezruiz commented Oct 30, 2024

azure-pipelines bot commented Oct 30, 2024

PureWeen commented Nov 1, 2024

albyrock87 commented Nov 6, 2024

albyrock87 commented Sep 18, 2024 •

edited

Loading

albyrock87 commented Sep 20, 2024 •

edited

Loading