[Windows] Fix for the screen does not display when changing the CurrentPage of a TabbedPage #25690
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Could you rebase to fix the conflicts? Thanks in advance. |
|
@Tamilarasan-Paranthaman may you check if #25664 solves this issue too? |
|
/rebase |
|
@PureWeen, I have added test cases |
|
Closing this for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Root cause
While navigating to the next page, the MeasureOverride method is repeatedly called on the parent, which prevents the Arrange method from being called.
Description of change
The OnChildMeasureInvalidatedInternal method has been modified to ensure that measure invalidation is only propagated to the parent when necessary, preventing unnecessary repeated calls to OnChildMeasureInvalidatedInternal.
References
MeasureInvalidatedevent work correctly #23052Issues Fixed
Fixes #25518
Tested the behaviour in the following platforms
Screenshot
FixVideo.mp4