-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(deployment): pin ubuntu version used by github (#30871) #30907
Conversation
@dcolina thank you for all these changes.
This way we could make the change in one single place without introducing any code changes in the future. We can also manage several versions since some workflows (can't recall which ones) work better with specific ubuntu versions. |
…. An easy way to maintain.
…untu-version-used-by-github
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Requests
- Requested some changes with the readme's
- Did you manually test the fallback in the forked repo to make sure it works?
Questions that are not blockers
- When will we remove the fallback, or at least update it to fallback to 24.04 if no var provided?
- is there some way to define the full runs on value
ubuntu-${{ vars.UBUNTU_RUNNER_VERSION || '22.04' }}
once and have it inherited downstream? Just trying to keep pushing to fewer places we have to repeat ourselves :)
.github/actions/core-cicd/deployment/deploy-javascript-sdk/README.md
Outdated
Show resolved
Hide resolved
…untu-version-used-by-github
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great. Thanks for the changes and thoughts
Proposed Changes
UBUNTU_RUNNER_VERSION
must be set to24.04
; otherwise, workflows will default to using22.04
.Details
We conducted thorough testing with the following setups:
Ubuntu 22.04:
All runs completed successfully without any unusual behavior.
Ubuntu 24.04:
Similarly, all workflows ran correctly, with no anomalies observed.
Proposal
Next Steps
Fixes
#30871
This PR fixes: #30871