Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deployment): pin ubuntu version used by github (#30871) #30907

Merged
merged 6 commits into from
Dec 11, 2024

Conversation

dcolina
Copy link
Contributor

@dcolina dcolina commented Dec 10, 2024

Proposed Changes

  • This pull request proposes updating all Ubuntu runners in our CICD pipelines to version 24.04.
  • A new GitHub repository variable is needed. UBUNTU_RUNNER_VERSION must be set to 24.04; otherwise, workflows will default to using 22.04.

Details

We conducted thorough testing with the following setups:

Ubuntu 22.04:

  • Executed main CICD workflows (PR, Merge Queue, Trunk, and Nightly) on fork.
    All runs completed successfully without any unusual behavior.

Ubuntu 24.04:

  • Repeated the same tests with runners updated to 24.04.
    Similarly, all workflows ran correctly, with no anomalies observed.

Proposal

  • Given the successful results in both cases, we propose setting the runners directly to version 24.04 to streamline the update process.

Next Steps

  • Merge this PR to update the Ubuntu runners.
  • Monitor post-deployment to ensure stability across all workflows.

Fixes

#30871

This PR fixes: #30871

@dcolina dcolina requested a review from a team as a code owner December 10, 2024 17:31
@dcolina dcolina linked an issue Dec 10, 2024 that may be closed by this pull request
@victoralfaro-dotcms
Copy link
Contributor

@dcolina thank you for all these changes.
This has grown enough to make me wonder if we could take this opportunity to actually store this ubuntu version as a repo ENVIRONMENT VARIABLE.
At the workflows we could reference it like this:

  runs-on: ubuntu-{{ vars.UBUNTU_MAIN_VERSION }} # or any other name since I'm terrible at naming

This way we could make the change in one single place without introducing any code changes in the future. We can also manage several versions since some workflows (can't recall which ones) work better with specific ubuntu versions.

Copy link
Contributor

@sfreudenthaler sfreudenthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requests

  • Requested some changes with the readme's
  • Did you manually test the fallback in the forked repo to make sure it works?

Questions that are not blockers

  • When will we remove the fallback, or at least update it to fallback to 24.04 if no var provided?
  • is there some way to define the full runs on value ubuntu-${{ vars.UBUNTU_RUNNER_VERSION || '22.04' }} once and have it inherited downstream? Just trying to keep pushing to fewer places we have to repeat ourselves :)

.github/actions/core-cicd/api-limits-check/Readme.md Outdated Show resolved Hide resolved
.github/actions/core-cicd/cleanup-runner/Readme.md Outdated Show resolved Hide resolved
.github/actions/core-cicd/prepare-runner/README.md Outdated Show resolved Hide resolved
.github/actions/core-cicd/setup-java/README.md Outdated Show resolved Hide resolved
@dcolina
Copy link
Contributor Author

dcolina commented Dec 11, 2024

  • All the readme file (examples) have been updated.
  • Fallback was manually tested in the forked repo.
  • Fallback has been set to 24.04
  • There is no straightforward or simple way to define the runs-on configuration in a single location and reference it across all workflows in the project. The available alternatives would require significantly more changes than we’d prefer, and they do not fully provide the desired solution—at least from a development perspective.

Copy link
Contributor

@sfreudenthaler sfreudenthaler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the changes and thoughts

@dcolina dcolina added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 8af2d78 Dec 11, 2024
36 checks passed
@dcolina dcolina deleted the issue-30871-pin-ubuntu-version-used-by-github branch December 11, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

pin ubuntu version used by github
5 participants