Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pin ubuntu version used by github #30871

Closed
sfreudenthaler opened this issue Dec 6, 2024 · 2 comments · Fixed by #30907
Closed

pin ubuntu version used by github #30871

sfreudenthaler opened this issue Dec 6, 2024 · 2 comments · Fixed by #30907
Assignees
@dcolina
Labels
Team : Cloud Eng Type : CI/CD

Comments

@sfreudenthaler
Copy link
Contributor

github is changing version of ubuntu they're going to use in github runners. They're retagging latest tag.

We want to get in front of this and pin so we have reproducible builds and control the cutover to new versions.

Acceptance Criteria

  1. where we use latest pin to the current version we're using
  2. bring forward the ones we have pinned to older versions that are being deprecated. They should go to the same version as the rest from AC 1
@sfreudenthaler sfreudenthaler moved this to Current Sprint Backlog in dotCMS - Product Planning Dec 6, 2024
@bryanboza bryanboza removed the Team : Platform Platform Team label Dec 6, 2024
@dcolina dcolina self-assigned this Dec 9, 2024
@dcolina dcolina added Team : Platform Platform Team and removed Team : Platform Platform Team labels Dec 9, 2024
@dcolina dcolina moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Dec 9, 2024
dcolina added a commit to dotCMS/core-workflow-test that referenced this issue Dec 9, 2024
@dcolina
dotCMS#30871 replacing ubuntu latest and 20.04 by 22.04.
aa07703
github-merge-queue bot pushed a commit to dotCMS/core-workflow-test that referenced this issue Dec 9, 2024
@dcolina
dotCMS#30871 replacing ubuntu latest and 20.04 by 22.04. (#183)
569a980 
### Proposed Changes

This pull request updates the GitHub Actions workflows to use Ubuntu
22.04 instead of using `latest` tag and older versions (like 20.04).

Key changes include:

* Updated the `runs-on` field to `ubuntu-22.04` across multiple workflow
files to ensure consistency.
@dcolina dcolina moved this from In Progress to In Review in dotCMS - Product Planning Dec 10, 2024
dcolina added a commit to dotCMS/core-workflow-test that referenced this issue Dec 10, 2024
@dcolina
dotCMS#30871 replacing ubuntu-22.04 by ubuntu-24.04 in all workflows.
35f11a6
dcolina added a commit that referenced this issue Dec 10, 2024
@dcolina
#30871 All the ubuntu runners pinned on 24.04.
713db45
@dcolina dcolina linked a pull request Dec 10, 2024 that will close this issue
chore(deployment): pin ubuntu version used by github (#30871) #30907
Merged
@github-actions GitHub Actions
Copy link

PRs:

@dcolina dcolina mentioned this issue Dec 10, 2024
Merged
dcolina added a commit to dotCMS/core-workflow-test that referenced this issue Dec 11, 2024
@dcolina
dotCMS#30871 Replacing ubuntu-24.04 version with vars.UBUNTU_RUNNER_V…
3fc586d 
…ERSION. An easy way to maintain.
dcolina added a commit that referenced this issue Dec 11, 2024
@dcolina
#30871 Replacing ubuntu-24.04 version with vars.UBUNTU_RUNNER_VERSION…
699f9dd 
…. An easy way to maintain.
dcolina added a commit that referenced this issue Dec 11, 2024
@dcolina
#30871 UBUNTU_RUNNER_VERSION fallback (24.04) and readme files (examp…
be421eb 
…les) updated.
github-merge-queue bot pushed a commit that referenced this issue Dec 11, 2024
@dcolina
chore(deployment): pin ubuntu version used by github (#30871) (#30907)
8af2d78 
### Proposed Changes

* This pull request proposes updating all Ubuntu runners in our CICD
pipelines to version 24.04.
* A new GitHub repository variable is needed. `UBUNTU_RUNNER_VERSION`
must be set to `24.04`; otherwise, workflows will default to using
`22.04`.

## Details
We conducted thorough testing with the following setups:

*Ubuntu 22.04:*

- Executed main CICD workflows (PR, Merge Queue, Trunk, and Nightly) on
fork.
All runs completed successfully without any unusual behavior.

*Ubuntu 24.04:*

- Repeated the same tests with runners updated to 24.04.
Similarly, all workflows ran correctly, with no anomalies observed.

### Proposal

- Given the successful results in both cases, we propose setting the
runners directly to version 24.04 to streamline the update process.

### Next Steps

- Merge this PR to update the Ubuntu runners.
- Monitor post-deployment to ensure stability across all workflows.

### Fixes
#30871
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Dec 11, 2024
@dcolina
Copy link
Contributor

dcolina commented Dec 12, 2024

Since no issues have arisen after the merge, and considering that several PR checks have been executed, multiple branches have been merged, and the latest nightly process was completed successfully, we are marking this task as approved and closing it.

If any issues or errors arise in the future, they will be addressed in a separate issue.

@dcolina dcolina moved this from Internal QA to Done in dotCMS - Product Planning Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dcolina dcolina

Labels
Team : Cloud Eng Type : CI/CD
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(deployment): pin ubuntu version used by github (#30871) dotCMS/core
3 participants
@bryanboza @dcolina @sfreudenthaler