-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 30411 refactor collector payload key names #30784
Merged
jdotcms
merged 9 commits into
main
from
issue-30411-refactor-collector-payload-key-names
Dec 6, 2024
Merged
Issue 30411 refactor collector payload key names #30784
jdotcms
merged 9 commits into
main
from
issue-30411-refactor-collector-payload-key-names
Dec 6, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do you test if this change break the CA queries?
freddyDOTCMS
approved these changes
Nov 27, 2024
dsilvam
approved these changes
Nov 28, 2024
Missing tests? @jdotcms |
dsilvam
approved these changes
Nov 29, 2024
Quality Gate passedIssues Measures |
…or-collector-payload-key-names
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Renaming a lot of properties and adding a few extras
This PR fixes: #30411