Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Match the CA attribute with the Elaticsearch attribute #30411

Closed
freddyDOTCMS opened this issue Oct 18, 2024 · 3 comments · Fixed by #30784
Closed

Match the CA attribute with the Elaticsearch attribute #30411

freddyDOTCMS opened this issue Oct 18, 2024 · 3 comments · Fixed by #30784

Comments

@freddyDOTCMS
Copy link
Contributor

Parent Issue

No response

Problem Statement

Right now the CA attribute are totally different from what we used in ES, for example, the Contentlet's ID is saved as "identifier" , we used: contentId, also we have others fields that have the same value like : pageId, fileId, vanityId, the only different is that this attribute are NULL when is not the right type on Contentlet, for example pageId is NULL is the COntentlet is a Image.

Also we are not saving some values that we need like the ContentType variable Name, or the Base Content Type, the list of attribute that we want to match with ES are:

Attribute that already exists in CA but we need to rename:

  • contentId - > identifier
  • contenTitle -> title
  • urlMapContentTypeVarName -> contentType
  • renderMode -> turn into to boolean live and working
  • language -> languageId
  • host -> conHost
  • vanityForwardTo -> fowardTo
  • vanityResponse -> action
  • urlMapWasHit and wasVanityHit -> Join in just one attribute that tell if Vanity or URL MAP was used

We need to removed some attribute too like:

  • isDetailPage
  • urlMapContentDetailId
  • urlMapContentDetailTitle
  • urlMapContentId
  • urlMapContentTypeName
  • urlMapContentTypeVarName

Also we need to include some attribute that we are not collecting right now:

  • baseType
  • Path

Steps to Reproduce

Start Analytics generate some CA data
Go to CubeJS Server and check the field names

Acceptance Criteria

We need to rename, removed and create the fields describe before

dotCMS Version

latest

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

No response

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

Copy link

@jdotcms
Copy link
Contributor

jdotcms commented Nov 27, 2024

This is a refactoring of the keys to try to get close of elastic keys.
it wont be testable until get the issue to make the changes on clickhouse and elastic, but we are gonna merge without QA needed

jdotcms added a commit that referenced this issue Nov 29, 2024
jdotcms added a commit that referenced this issue Nov 29, 2024
jdotcms added a commit that referenced this issue Dec 2, 2024
jdotcms added a commit that referenced this issue Dec 3, 2024
jdotcms added a commit that referenced this issue Dec 3, 2024
jdotcms added a commit that referenced this issue Dec 4, 2024
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Dec 6, 2024
@jcastro-dotcms jcastro-dotcms self-assigned this Dec 6, 2024
@jcastro-dotcms
Copy link
Contributor

INTERNAL QA: PASSED ✅

  • Docker Image: trunk_e32a4d3

Existing variable names are now matching what was described in the ticket. As @jdotcms said, another ticket will be created to match the same changes in the ClickHouse schema.

@jcastro-dotcms jcastro-dotcms reopened this Dec 6, 2024
@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Dec 6, 2024
@jcastro-dotcms jcastro-dotcms moved this from Current Sprint Backlog to QA - Backlog in dotCMS - Product Planning Dec 6, 2024
@jcastro-dotcms jcastro-dotcms removed their assignment Dec 9, 2024
@dsilvam dsilvam moved this from QA - Backlog to Done in dotCMS - Product Planning Dec 11, 2024
@dsilvam dsilvam closed this as completed Dec 11, 2024
@github-project-automation github-project-automation bot moved this from Done to Internal QA in dotCMS - Product Planning Dec 11, 2024
@dsilvam dsilvam moved this from Internal QA to Done in dotCMS - Product Planning Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants