chore(uve): FTM - Implement look feel new UVE toolbar #30745
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KevinDavilaDotCMS
requested review from
zJaaal,
rjvelazco,
fmontes,
oidacra and
nicobytes
|
fmontes
approved these changes
Nov 21, 2024
zJaaal
approved these changes
Nov 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Screen.Recording.2024-11-21.at.3.01.25.PM.mov
This pull request includes enhancements to the
dot-uve-toolbarcomponent in theedit-emaportlet. The changes focus on improving the toolbar's functionality and updating the tests to ensure comprehensive coverage.Enhancements to the toolbar component:
dot-uve-toolbar.component.html: Replaced the placeholder text with a toolbar containing buttons for preview, bookmark, copy URL, API link, and spans for experiments, language selector, persona selector, and workflows.Styling updates:
dot-uve-toolbar.component.scss: Added styles to align items and set gaps for the toolbar groups using variables.Testing improvements:
dot-uve-toolbar.component.spec.ts: Refactored tests to use@ngneat/spectatorfor better readability and added tests for each toolbar button and span.Module imports:
dot-uve-toolbar.component.ts: ImportedButtonModule,ToolbarModule, andDotMessagePipeto support the new toolbar functionality.This PR fixes: #30595