Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implementation ( Edit Content): #30212 Display Toast Message on Contentlet Save #30659

Merged
merged 1 commit into from
Nov 18, 2024

Conversation

hmoreras
Copy link
Contributor

@hmoreras hmoreras commented Nov 14, 2024

Proposed Changes

  • Move ToastModule to edit-content.shell.component.ts, to support notifications on route change.

This PR fixes: #30212

@hmoreras hmoreras requested review from oidacra, nicobytes and rjvelazco and removed request for oidacra and nicobytes November 14, 2024 17:53
@hmoreras hmoreras enabled auto-merge November 14, 2024 17:54
Copy link

@hmoreras hmoreras requested a review from nicobytes November 18, 2024 15:44
@nicobytes nicobytes requested a review from Copilot November 18, 2024 20:37
@hmoreras hmoreras added this pull request to the merge queue Nov 18, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 5 changed files in this pull request and generated no suggestions.

Files not reviewed (1)
  • core-web/libs/edit-content/src/lib/feature/edit-content/edit-content.layout.component.html: Language not supported
Merged via the queue into main with commit d01e188 Nov 18, 2024
23 checks passed
@hmoreras hmoreras deleted the issue-30212-toast-feedback branch November 18, 2024 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display Toast Message on Contentlet Save
3 participants