Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display Toast Message on Contentlet Save #30212

Closed
2 tasks done
Tracked by #30012
oidacra opened this issue Oct 2, 2024 · 6 comments · Fixed by #30615 or #30659
Closed
2 tasks done
Tracked by #30012

Display Toast Message on Contentlet Save #30212

oidacra opened this issue Oct 2, 2024 · 6 comments · Fixed by #30615 or #30659

Comments

@oidacra
Copy link
Member

oidacra commented Oct 2, 2024

Parent Issue

#30012

User Story

As a content editor, I want to see a toast notification when a content let is saved or encounters an error, so I can quickly understand the outcome of my action.

Acceptance Criteria

  • A success toast message is displayed when a content let is successfully saved
  • The toast messages use the PrimeNG Toast component
  • Success messages should be green and disappear after 3 seconds

image

Proposed Objective

  • User Experience

Proposed Priority

  • Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

N/A

Assumptions & Initiation Needs

  • PrimeNG is already integrated into the project
  • The content let saving mechanism is already in place

Quality Assurance Notes & Workarounds

@oidacra oidacra changed the title Implement a message when save or error Display Toast Message on Content Let Save or Error Oct 2, 2024
@oidacra oidacra moved this from New to Next 1-3 Sprints in dotCMS - Product Planning Oct 2, 2024
@oidacra oidacra changed the title Display Toast Message on Content Let Save or Error Display Toast Message on Contentlet Save or Error Oct 2, 2024
@john-thomas-dotcms john-thomas-dotcms moved this from Next 1-3 Sprints to Current Sprint Backlog in dotCMS - Product Planning Oct 30, 2024
@jdotcms
Copy link
Contributor

jdotcms commented Nov 1, 2024

I wonder if you do not need also a toast when the content is properly (the workflow) executed in the backend

@hmoreras hmoreras self-assigned this Nov 5, 2024
@hmoreras hmoreras moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Nov 5, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 11, 2024
…ntlet Save (#30615)

### Proposed Changes
* Add a toast when a workflow is executed. 



### Screenshots
<img width="1279" alt="image"
src="https://github.com/user-attachments/assets/71165ed7-364b-49e6-8ac1-77bff65c4758">
@github-project-automation github-project-automation bot moved this from In Progress to Internal QA in dotCMS - Product Planning Nov 11, 2024
@hmoreras hmoreras changed the title Display Toast Message on Contentlet Save or Error Display Toast Message on Contentlet Save Nov 11, 2024
@hmoreras hmoreras removed their assignment Nov 11, 2024
@hmoreras
Copy link
Contributor

Note to QA:

Add a toast when a workflow is executed.

image

@jcastro-dotcms
Copy link
Contributor

INTERNAL QA: FAILED ❌

  • Docker Image: trunk_786c18d

The toast notification is only showing up when clicking the Publish button, but not the Save button.

Steps to Reproduce:

  1. Create a test Content Type with a single Title field, and activate the new Edit Mode for it.
  2. Create a new Contentlet of such a type, and click Save.
  3. You will not get the toast.
  4. Click the Publish button, and you'll see the toast this time.

@github-project-automation github-project-automation bot moved this from Internal QA to Current Sprint Backlog in dotCMS - Product Planning Nov 12, 2024
github-merge-queue bot pushed a commit that referenced this issue Nov 18, 2024
…ntlet Save (#30659)

### Proposed Changes
* Move `ToastModule ` to `edit-content.shell.component.ts`, to support
notifications on route change.
@hmoreras hmoreras moved this from In Review to Internal QA in dotCMS - Product Planning Nov 19, 2024
@hmoreras hmoreras removed their assignment Nov 19, 2024
@oidacra
Copy link
Member Author

oidacra commented Nov 19, 2024

IQA Passed.

@oidacra oidacra moved this from Internal QA to QA - Backlog in dotCMS - Product Planning Nov 19, 2024
@josemejias11
Copy link
Contributor

Approved: Tested on trunk_396487e, Docker, macOS 14.5, FF v126.0.1

@josemejias11 josemejias11 moved this from QA - In Progress to Done in dotCMS - Product Planning Nov 21, 2024
@dsilvam dsilvam closed this as completed Nov 27, 2024
@github-project-automation github-project-automation bot moved this from Done to Internal QA in dotCMS - Product Planning Nov 27, 2024
@dsilvam dsilvam moved this from Internal QA to Done in dotCMS - Product Planning Nov 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment