Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(deployment): Pass SDKMAN_JAVA_VERSION when building deployment image (#29685) #29757

Merged
merged 1 commit into from
Aug 27, 2024
Merged

fix(deployment): Pass SDKMAN_JAVA_VERSION when building deployment image (#29685) #29757

merged 1 commit into from
Aug 27, 2024

Conversation

spbolton
Copy link
Contributor

@spbolton spbolton commented Aug 27, 2024 •
edited by github-actions bot
Loading

Proposed Changes

  • Ensure that correct java version is used by passing SDKMAN_JAVA_VERSION build arg during deployment image build
  • Remove confusion by replacing specific default for SDKMAN_JAVA_VERSION from Dockerfile requiring it to be set.

Change will only have impact in deployment step in trunk workflow.

Checklist

  • Tests
  • Translations
  • Security Implications Contemplated (add notes if applicable)

Additional Info

Related to #29685 (Update Project Java Version to 21.04ms and Ensure ).

Screenshots

Original Updated
** original screenshot ** ** updated screenshot **

This PR fixes: #29685

@spbolton spbolton requested a review from a team as a code owner August 27, 2024 11:23
@spbolton spbolton linked an issue Aug 27, 2024 that may be closed by this pull request
Update Project Java Version to 21.04-ms and Ensure Successful Build and Test Completion #29685
Closed
@dotcms-sonarqube dotCMS-sonarqube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@spbolton spbolton changed the title fix(deployment): Update Project Java Version to 21.04ms and Ensure (#29685) fix(deployment): Pass SDKMAN_JAVA_VERSION when building deployment image (#29685) Aug 27, 2024
dcolina
dcolina approved these changes Aug 27, 2024
View reviewed changes
Copy link
Contributor

@dcolina dcolina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽

@spbolton spbolton added this pull request to the merge queue Aug 27, 2024
Merged via the queue into master with commit d068127 Aug 27, 2024
31 checks passed
@spbolton spbolton deleted the issue-29685-update-project-java-version-to-2104-ms-and-ensure branch August 27, 2024 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcolina dcolina dcolina approved these changes

@jgambarios jgambarios jgambarios approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update Project Java Version to 21.04-ms and Ensure Successful Build and Test Completion
3 participants
@spbolton @jgambarios @dcolina