-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Project Java Version to 21.04-ms and Ensure Successful Build and Test Completion #29685
Comments
### Proposed Changes * In this PR we update project java version to `21.0.4-ms` ### Fixes #29685 --------- Co-authored-by: Steve Freudenthaler <[email protected]>
Internal QA: Apparently some changes are missing. The latest docker image generated is running Java 11. Besides, it seems like there are some changes missing from this PR |
The docker image created during CICD build/test is working fine but the image is regenerated in the master deployment phase, we were missing passing the build-arg to specify the base image to use in this step and it was falling back to the default in the Docker file. We need to be more clear about what changes are missing from the PR as it is old and does not reflect some changes that have already been deployed in different ways into master. There are also some changes that were purposely not included in this PR and should be added after initial Java 21 was merged. The new garbage collection options are only supported with Java 21, the old Java 11 options may not be preferable for Java 21, and we may also have some warnings after switch over but It is preferable to have smaller PRs and to have and test a commit where we are only changing the Java version essentially a commit that is compatible with both, and then follow up with changes that are only supported in the new version. We can then also distinguish between issues that may be caused by those tomcat parameter changes from the core java change. There may be something missing from the PR we want to include but if it is not something that is going to cause things to break when running on java 21 they should be separately included. |
…age (#29685) (#29757) ### Proposed Changes * Ensure that correct java version is used by passing SDKMAN_JAVA_VERSION build arg during deployment image build * Remove confusion by replacing specific default for SDKMAN_JAVA_VERSION from Dockerfile requiring it to be set. Change will only have impact in deployment step in trunk workflow. ### Checklist - [ ] Tests - [ ] Translations - [ ] Security Implications Contemplated (add notes if applicable) ### Additional Info Related to #29685 (Update Project Java Version to 21.04ms and Ensure ). ### Screenshots Original | Updated :-------------------------:|:-------------------------: ** original screenshot ** | ** updated screenshot **
Passed Internal QA
VideoChecking Build SDKMan Base Java Image Workflow and Java version in dotCMS instanceiqa-29685-update-project-java-version-to-2104-ms-and-ensure-successful-build-and-test-completion.movChecking the Java version directly in the terminaliqa-29685-update-project-java-version-to-2104-ms-and-ensure-successful-build-and-test-completion-terminal.mov |
Fixed, tested on the latest trunk // Docker // FF |
Parent Issue
User Story
As a developer, I need to update the Java version in our project to 21.0.4-ms. This involves building the base Java image 21.0.4-ms using the GitHub workflow 'Build SDKMan Base Java Image'. It is crucial to ensure that the project compiles correctly with the new Java version and that all integration flow tests complete successfully.
Acceptance Criteria
Proposed Objective
Core Features
Proposed Priority
Priority 1 - Show Stopper
dotCMS Version
N/A
External Links
N/A
Assumptions & Initiation Needs
Quality Assurance Notes & Workarounds
Sub-Tasks & Estimates
N/A
The text was updated successfully, but these errors were encountered: