Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

implementation(PrimeNG-17): #29664 Fix p-dropdown issues and breaking change #29704

Merged
merged 1 commit into from
Aug 22, 2024
Merged

implementation(PrimeNG-17): #29664 Fix p-dropdown issues and breaking change #29704

merged 1 commit into from
Aug 22, 2024

Conversation

hmoreras
Copy link
Contributor

@hmoreras hmoreras commented Aug 22, 2024 •
edited
Loading

Proposed Changes

  • remove attr autoDisplayFirst since will be deprecated; we have placeholders on all the cases actually don't make any difference based on the description: Whether to display the first item as the label if no placeholder is defined and value is null.
  • adding styles to remove the outline in the dropdown label / placeholder.

Screenshots

Before

image

After

image

@hmoreras hmoreras requested a review from nicobytes August 22, 2024 15:06
@hmoreras hmoreras linked an issue Aug 22, 2024 that may be closed by this pull request
PrimeNG v17: Fix p-dropdown issues and breaking change #29664
Closed
nicobytes
nicobytes approved these changes Aug 22, 2024
View reviewed changes
Copy link
Contributor

@nicobytes nicobytes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@nicobytes nicobytes merged commit 2a489ee into epic-primeng-upgrade Aug 22, 2024
1 check passed
@nicobytes nicobytes deleted the issue-29664 branch August 22, 2024 15:25
@nicobytes nicobytes mentioned this pull request Aug 22, 2024
Merged
9 tasks
github-merge-queue bot pushed a commit that referenced this pull request Aug 28, 2024
@nicobytes @oidacra
@spbolton @victoralfaro-dotcms @hmoreras
Epic about PrimeNG Upgrade (#29614)
f58464f 
### Parent Issue
#29058


### Objective

This is a PR to collect small PRs to upgrade from PrimeNG v15 to v17.

### PRs associated

- [x] #29057
- [x] #29624
- [x] #29562
- [x] #29650
- [x] #29658
- [x] #29674
- [x] #29704
- [x] #29706
- [x] #29737

---------

Co-authored-by: Arcadio Quintero <[email protected]>
Co-authored-by: spbolton <[email protected]>
Co-authored-by: Victor Alfaro <[email protected]>
Co-authored-by: Humberto Morera <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicobytes nicobytes nicobytes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

PrimeNG v17: Fix p-dropdown issues and breaking change
2 participants
@hmoreras @nicobytes