Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PrimeNG v17: Fix p-dropdown issues and breaking change #29664

Closed
Tracked by #29058
nicobytes opened this issue Aug 20, 2024 · 0 comments · Fixed by #29704
Closed
Tracked by #29058

PrimeNG v17: Fix p-dropdown issues and breaking change #29664

nicobytes opened this issue Aug 20, 2024 · 0 comments · Fixed by #29704
Assignees
@hmoreras
Labels
Merged QA : Not Needed Team : Falcon Type : Refactoring

Comments

@nicobytes
Copy link
Contributor

nicobytes commented Aug 20, 2024 •
edited
Loading

Parent Issue

#29058

Issues

  • The placeholder should not be highlighted.
  • Fix autoDisplayFirst input becuase was deprecated.

Screenshots

v15 v17
Screenshot 2024-08-20 at 12 32 10 PM Screenshot 2024-08-20 at 12 32 04 PM

Additional info

The branch for this card must be epic-primeng-upgrade, and the PR must target that branch.

Refs
@nicobytes nicobytes mentioned this issue Aug 20, 2024
Closed
@nicobytes nicobytes changed the title PrimeNG v17: Fix p-dropdown issues and breaking change PrimeNG v17: Fix p-dropdown issues Aug 20, 2024
@nicobytes nicobytes changed the title PrimeNG v17: Fix p-dropdown issues PrimeNG v17: Fix p-dropdown issues and breaking change Aug 20, 2024
@nicobytes nicobytes moved this from New to Current Sprint Backlog in dotCMS - Product Planning Aug 20, 2024
@hmoreras hmoreras self-assigned this Aug 21, 2024
@hmoreras hmoreras moved this from Current Sprint Backlog to In Progress in dotCMS - Product Planning Aug 21, 2024
@hmoreras hmoreras linked a pull request Aug 22, 2024 that will close this issue
implementation(PrimeNG-17): #29664 Fix p-dropdown issues and breaking change #29704
Merged
@hmoreras hmoreras moved this from In Progress to In Review in dotCMS - Product Planning Aug 22, 2024
nicobytes pushed a commit that referenced this issue Aug 22, 2024
@hmoreras
implementation(PrimeNG-17): #29664 Fix p-dropdown issues and breaking…
2a489ee 
… change (#29704)

### Proposed Changes
* remove attr `autoDisplayFirst ` since will be deprecated; we have
placeholders on all the cases actually don't make any difference based
on the description: `Whether to display the first item as the label if
no placeholder is defined and value is null.`
* adding styles to remove the outline in the dropdown label /
placeholder.


### Screenshots

Before

<img width="382" alt="image"
src="https://github.com/user-attachments/assets/b0bdaeee-b6a8-4f0a-9dff-7127bbaf7086">



After 

<img width="379" alt="image"
src="https://github.com/user-attachments/assets/216d8416-1d9a-4276-8395-b1ef453b3eb8">
@github-project-automation github-project-automation bot moved this from In Review to Internal QA in dotCMS - Product Planning Aug 22, 2024
@nicobytes nicobytes moved this from Internal QA to Done in dotCMS - Product Planning Aug 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hmoreras hmoreras

Labels
Merged QA : Not Needed Team : Falcon Type : Refactoring
Projects
dotCMS - Product Planning
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

implementation(PrimeNG-17): #29664 Fix p-dropdown issues and breaking change dotCMS/core
2 participants
@nicobytes @hmoreras