fix(Page Properties): keep custom template after update #29669
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rjvelazco
requested review from
fmontes,
oidacra,
nicobytes,
hmoreras,
zJaaal,
valentinogiardino and
KevinDavilaDotCMS
This was
linked to
issues
Aug 20, 2024
…n-in-page-properties-is-not-displaying-the-expected-custom-template-value
zJaaal
approved these changes
Aug 20, 2024
KevinDavilaDotCMS
approved these changes
Aug 20, 2024
|
valentinogiardino
approved these changes
Aug 20, 2024
nicobytes
approved these changes
Aug 20, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
fmontes
approved these changes
Aug 21, 2024
rjvelazco
deleted the
issue-29034-templates-the-template-dropdown-in-page-properties-is-not-displaying-the-expected-custom-template-value
branch
spbolton
pushed a commit
that referenced
this pull request
Aug 21, 2024
* fix(template): Page content is deleted after changing page properties - #29569 * fix(template): Page content is deleted when changing language - #29572 * fix(template): Keep custom template after update - #29034 https://github.com/user-attachments/assets/b1348572-89b9-404d-9df3-7cae19bd688a https://github.com/user-attachments/assets/4f3079da-77bf-4616-a031-7a3802c40d39 https://github.com/user-attachments/assets/23217700-1800-4ed7-ad7e-9ccc75fafac3
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Videos
Page content is deleted after changing page properties
page-content-is-deleted-after-change-page-properties.mov
Page content is deleted when changing language
page-content-is-deleted-when-change-language.mov
Keep custom template after update
keep-custom-template-after-update.mov
This PR fixes: #29034