[Templates] : The 'Template' dropdown in Page Properties is not displaying the expected Custom Template value

[jcastro-dotcms]

Parent Issue

No response

Problem Statement

The Template dropdown in the Page Properties modal is NOT displaying the correct value when a custom Template is generated. When you update the page's layout, it displays System Template (System Host) instead.

If you check the contentlet table in the database, in the contentlet_as_json column, the Template data points to a custom Template. This means there might be a problem at UI level. This will confuse users as they will think their HTML Page is using the System Template, which is not correct.

Steps to Reproduce

1. Create a test HTML Page using the Default Template.
2. Add a test Rich Text to the page.
3. Click the LAYOUT button and add a new row above or below the existing one. Click the CONTENT button.
4. Finally, click the PROPERTIES button, You'll see that the value of the Template dropdown is System Template (System Host)

Acceptance Criteria

The Template dropdown must indicate that the current Template is actually a Custom Template, just like it used to.

dotCMS Version

Latest master.

Proposed Objective

Core Features

Proposed Priority

Priority 2 - Important

External Links... Slack Conversations, Support Tickets, Figma Designs, etc.

No response

Assumptions & Initiation Needs

This issue might be related to:

• refactor: delete templateAjax #28563

Quality Assurance Notes & Workarounds

No response

Sub-Tasks & Estimates

No response

[jdotcms]

I will take a look

[nollymar]

This issue is happening after the changes applied on this PR.

I could identified that the /api/v1/templates endpoint is called multiple times and the last call removes the Custom Page Layout from the dropdown list. After removing these lines , the issue gets fixed. However, when you select the File Template Advanced example, the dropdown breaks again.

Other findings:

• the api/v1/templates/64269d16-2710-4919-88ec-3b09c89ea004/working is called twice
• the /api/v1/templates/image fails when no image is found. In my opinion, we shouldn't log that exception because the template image is optional
• Code duplication

I suggest to clean up the logic in the complete custom field to avoid unnecessary calls that might be affecting the field's behavior.

[rjvelazco]

We are going to address this issue for the UVE here but for the old Edit Page is going to be in a separate ticket #29697, @nollymar

[zJaaal]

IQA Passed

Now the Template field is populating correctly

Docker Image: [dotcms/dotcms:trunk_36f72e4]

Screenshot

Screen.Recording.2024-08-26.at.1.mp4

[bryanboza]

We lost the notification when you apply some change here:

Screen.Recording.2024-08-26.at.2.29.38.PM.mov

[rjvelazco]

@bryanboza I updated the QA server with the latest trunk image dotcms/dotcms:trunk_2f3045b [dotcms/dotcms Tags] and I'm not able to reproduce the issue in any supported Browser. I used the System Template, Default Template, and a Custom Page Template to test the issue. Let me know the image, starter, and the template you used

I noticed you are testing in the old page editor in your local environment and in the UVE editor on the QA server.

If this is not happening in the QA: Server/UVE we should not add the Needs Work label

Videos

Default Template

iqa-29034-templates-the-template-dropdown-in-page-properties-is-not-displaying-the-expected-custom-template-value.mov

System Template

iqa-29034-templates-the-template-dropdown-in-page-properties-is-not-displaying-the-expected-custom-template-value-system-template.mov

[bryanboza]

ok, this is something related to the new edit mode, tested in the last trunk with the new edit mode and this is working as expected.