-
Notifications
You must be signed in to change notification settings - Fork 467
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(sdk): Create Astro Example for UVE #29665
Merged
zJaaal
merged 60 commits into
master
from
29393-sdk-create-dotcms-example-for-javascript-framework-astro
Sep 4, 2024
Merged
chore(sdk): Create Astro Example for UVE #29665
zJaaal
merged 60 commits into
master
from
29393-sdk-create-dotcms-example-for-javascript-framework-astro
Sep 4, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zJaaal
requested review from
fmontes,
oidacra,
nicobytes,
hmoreras,
rjvelazco,
KevinDavilaDotCMS and
valentinogiardino
August 20, 2024 16:45
…ript-framework-astro
…k-astro' of https://github.com/dotCMS/core into 29393-sdk-create-dotcms-example-for-javascript-framework-astro
…ript-framework-astro
…ript-framework-astro
…k-astro' of https://github.com/dotCMS/core into 29393-sdk-create-dotcms-example-for-javascript-framework-astro
…ript-framework-astro
…ript-framework-astro
…ript-framework-astro
KevinDavilaDotCMS
approved these changes
Sep 4, 2024
fmontes
approved these changes
Sep 4, 2024
Quality Gate passedIssues Measures |
zJaaal
deleted the
29393-sdk-create-dotcms-example-for-javascript-framework-astro
branch
September 4, 2024 22:02
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 4, 2024
…#29868) ## Proposed Changes * Add extra logic to avoid access to `undefined` on NextJS and [Astro Example](#29665) ### Note Angular does not have this problem, because Calendar Event is not implemented in the Angular Example ## Screenshots ### NextJS https://github.com/user-attachments/assets/73999bf0-a4a3-4f4a-98e3-272b94552797 ### Astro https://github.com/user-attachments/assets/09881f0b-e322-41bf-8bf2-f0c49aac9a51 ### Angular (No changes) https://github.com/user-attachments/assets/2166c975-68a5-43ca-b701-28b7157f842e
dsolistorres
pushed a commit
that referenced
this pull request
Sep 18, 2024
# Proposed changes 1. Add new Astro project under `examples` folder 2. Install necessary dependencies to make it work as the other examples (Tailwind and Vercel plugin) 3. Add env file 4. Install `client` and `react` SDKs 5. Create React components to interop Astro with the React SDK 6. Clean the project by creating types and centralizing logic 7. Update readme file to add steps of how to set it up ## Screenshot https://github.com/user-attachments/assets/4d5f151e-169d-4bfa-b62d-b2447fe84f23 --------- Co-authored-by: Freddy Montes <[email protected]>
dsolistorres
pushed a commit
that referenced
this pull request
Sep 18, 2024
…#29868) ## Proposed Changes * Add extra logic to avoid access to `undefined` on NextJS and [Astro Example](#29665) ### Note Angular does not have this problem, because Calendar Event is not implemented in the Angular Example ## Screenshots ### NextJS https://github.com/user-attachments/assets/73999bf0-a4a3-4f4a-98e3-272b94552797 ### Astro https://github.com/user-attachments/assets/09881f0b-e322-41bf-8bf2-f0c49aac9a51 ### Angular (No changes) https://github.com/user-attachments/assets/2166c975-68a5-43ca-b701-28b7157f842e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed changes
examples
folderclient
andreact
SDKsScreenshot
Screen.Recording.2024-08-23.at.4.mp4
This PR fixes: #29393